Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2009643003: [Mac][Material Design] Restore bookmark icons to default favicon. (Closed)

Created:
4 years, 7 months ago by shrike
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Restore bookmark icons to default favicon. The Material Design bookmark buttons incorrectly used the location_bar_http vector icon to display a document icon for the default favicon. This cl adds default favicon vector icons based on the original version of the location_bar_http vector, and changes the bookmark buttons to use them. R=avi@chromium.org, estade@chromium.org BUG=614539 Committed: https://crrev.com/a0776f8a55b798c81fc142ea531c9d8a762c2c85 Cr-Commit-Position: refs/heads/master@{#396020}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Switch to OMNIBOX_HTTP. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
shrike
PTAL estade@ Additions to ui/gfx/vector_icons avi@ chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
4 years, 7 months ago (2016-05-25 01:13:36 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 7 months ago (2016-05-25 03:34:59 UTC) #2
Evan Stade
https://codereview.chromium.org/2009643003/diff/1/ui/gfx/vector_icons/default_favicon.1x.icon File ui/gfx/vector_icons/default_favicon.1x.icon (left): https://codereview.chromium.org/2009643003/diff/1/ui/gfx/vector_icons/default_favicon.1x.icon#oldcode7 ui/gfx/vector_icons/default_favicon.1x.icon:7: LINE_TO, 4, 14, this is almost identical to omnibox_http.icon ...
4 years, 7 months ago (2016-05-25 17:23:49 UTC) #3
shrike
On 2016/05/25 17:23:49, Evan Stade wrote: > https://codereview.chromium.org/2009643003/diff/1/ui/gfx/vector_icons/default_favicon.1x.icon > File ui/gfx/vector_icons/default_favicon.1x.icon (left): > > https://codereview.chromium.org/2009643003/diff/1/ui/gfx/vector_icons/default_favicon.1x.icon#oldcode7 ...
4 years, 7 months ago (2016-05-25 17:36:42 UTC) #4
Evan Stade
On 2016/05/25 17:36:42, shrike wrote: > On 2016/05/25 17:23:49, Evan Stade wrote: > > > ...
4 years, 7 months ago (2016-05-25 18:01:21 UTC) #5
shrike
On 2016/05/25 18:01:21, Evan Stade wrote: > Yes, people should be careful about searching for ...
4 years, 7 months ago (2016-05-25 18:23:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009643003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009643003/20001
4 years, 7 months ago (2016-05-25 21:08:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 22:47:52 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 22:49:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0776f8a55b798c81fc142ea531c9d8a762c2c85
Cr-Commit-Position: refs/heads/master@{#396020}

Powered by Google App Engine
This is Rietveld 408576698