Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2009643002: Motown: Implement MediaTimelineController and use it. (Closed)

Created:
4 years, 7 months ago by dalesat
Modified:
4 years, 6 months ago
Reviewers:
kulakowski
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Motown: Implement MediaTimelineController and use it. Implemented MediaTimelineController, which aggregates multiple MediaTimelineControlSites, and changed MediaPlayerImpl to use the controller. R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ce913b53e2545ddd4d4a565997d0816e8ef90a22

Patch Set 1 #

Patch Set 2 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+597 lines, -114 lines) Patch
M mojo/dart/packages/mojo_services/lib/mojo/media/media_factory.mojom.dart View 6 chunks +92 lines, -0 lines 0 comments Download
M mojo/services/media/control/interfaces/media_factory.mojom View 2 chunks +4 lines, -0 lines 0 comments Download
M services/media/factory_service/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/media/factory_service/factory_service.h View 1 chunk +3 lines, -0 lines 0 comments Download
M services/media/factory_service/factory_service.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M services/media/factory_service/media_player_impl.h View 4 chunks +16 lines, -25 lines 0 comments Download
M services/media/factory_service/media_player_impl.cc View 1 10 chunks +45 lines, -86 lines 0 comments Download
A services/media/factory_service/media_timeline_controller_impl.h View 1 chunk +161 lines, -0 lines 0 comments Download
A services/media/factory_service/media_timeline_controller_impl.cc View 1 chunk +264 lines, -0 lines 0 comments Download
M services/media/framework/util/callback_joiner.h View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dalesat
Please take a look. This is the last of the timing-related CLs for now. Thanks!
4 years, 7 months ago (2016-05-24 21:48:38 UTC) #3
kulakowski
lgtm
4 years, 7 months ago (2016-05-25 03:07:27 UTC) #4
dalesat
4 years, 6 months ago (2016-05-25 19:17:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ce913b53e2545ddd4d4a565997d0816e8ef90a22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698