Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 2009553002: Add Wasm SIMD opcodes. (Closed)

Created:
4 years, 7 months ago by gdeepti
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add Wasm SIMD opcodes. - Add Simd128 type to Wasm AST types - Seperate out generic SIMD Machine ops - Opcodes added as per Wasm SIMD opcode table prototype. All opcodes except Bool8x16, Bool16x8 and S128 Load/Store opcodes added. Committed: https://crrev.com/0f777211d72a10d976d55a490f4f2b6e3e4bb695 Cr-Commit-Position: refs/heads/master@{#36506}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix shuffle/swizzle signatures #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -26 lines) Patch
M src/compiler/opcodes.h View 2 chunks +17 lines, -14 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/wasm-linkage.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/wasm/ast-decoder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/wasm/module-decoder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 1 12 chunks +165 lines, -12 lines 2 comments Download

Messages

Total messages: 15 (7 generated)
gdeepti
4 years, 7 months ago (2016-05-24 17:29:20 UTC) #3
bradnelson
lgtm, but need ben for owners
4 years, 7 months ago (2016-05-24 19:47:13 UTC) #4
titzer
lgtm other than swizzle signatures https://codereview.chromium.org/2009553002/diff/1/src/wasm/wasm-opcodes.h File src/wasm/wasm-opcodes.h (right): https://codereview.chromium.org/2009553002/diff/1/src/wasm/wasm-opcodes.h#newcode362 src/wasm/wasm-opcodes.h:362: V(I16x8Swizzle, 0xe54d, s_siiii) \ ...
4 years, 7 months ago (2016-05-25 07:38:39 UTC) #5
gdeepti
https://codereview.chromium.org/2009553002/diff/1/src/wasm/wasm-opcodes.h File src/wasm/wasm-opcodes.h (right): https://codereview.chromium.org/2009553002/diff/1/src/wasm/wasm-opcodes.h#newcode362 src/wasm/wasm-opcodes.h:362: V(I16x8Swizzle, 0xe54d, s_siiii) \ On 2016/05/25 07:38:39, titzer wrote: ...
4 years, 7 months ago (2016-05-25 09:17:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009553002/20001
4 years, 7 months ago (2016-05-25 09:18:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 09:54:16 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0f777211d72a10d976d55a490f4f2b6e3e4bb695 Cr-Commit-Position: refs/heads/master@{#36506}
4 years, 7 months ago (2016-05-25 09:56:56 UTC) #13
aseemgarg
4 years, 6 months ago (2016-05-27 23:59:37 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/2009553002/diff/20001/src/wasm/wasm-opcodes.h
File src/wasm/wasm-opcodes.h (right):

https://codereview.chromium.org/2009553002/diff/20001/src/wasm/wasm-opcodes.h...
src/wasm/wasm-opcodes.h:286: V(F32x4ExtractLane, 0xe501, f_si)    \
probably better to take this and similar opcodes out into separate Macro and
implement them without the signature (they will become separate cases in
DecodeFunctionBody). The lane id should be an an operand instead of a parameter.

https://codereview.chromium.org/2009553002/diff/20001/src/wasm/wasm-opcodes.h...
src/wasm/wasm-opcodes.h:329: V(I32x4Select, 0xe52c, s_sss)        \
These won't work. There is no implementation for opcodes with 3 parameters.

Powered by Google App Engine
This is Rietveld 408576698