Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: chrome/browser/resources/options/browser_options.js

Issue 2009543002: Add storage manager overlay on Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.exportPath('options'); 5 cr.exportPath('options');
6 6
7 /** 7 /**
8 * @typedef {{actionLinkText: (string|undefined), 8 * @typedef {{actionLinkText: (string|undefined),
9 * childUser: (boolean|undefined), 9 * childUser: (boolean|undefined),
10 * hasError: (boolean|undefined), 10 * hasError: (boolean|undefined),
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 $('keyboard-settings-button').onclick = function(evt) { 344 $('keyboard-settings-button').onclick = function(evt) {
345 PageManager.showPageByName('keyboard-overlay'); 345 PageManager.showPageByName('keyboard-overlay');
346 chrome.send('coreOptionsUserMetricsAction', 346 chrome.send('coreOptionsUserMetricsAction',
347 ['Options_ShowKeyboardSettings']); 347 ['Options_ShowKeyboardSettings']);
348 }; 348 };
349 $('pointer-settings-button').onclick = function(evt) { 349 $('pointer-settings-button').onclick = function(evt) {
350 PageManager.showPageByName('pointer-overlay'); 350 PageManager.showPageByName('pointer-overlay');
351 chrome.send('coreOptionsUserMetricsAction', 351 chrome.send('coreOptionsUserMetricsAction',
352 ['Options_ShowTouchpadSettings']); 352 ['Options_ShowTouchpadSettings']);
353 }; 353 };
354 if (loadTimeData.getBoolean('enableStorageManager')) {
355 $('storage-manager-button').hidden = false;
356 $('storage-manager-button').onclick = function(evt) {
357 PageManager.showPageByName('storage');
358 };
359 }
354 } 360 }
355 361
356 // Search section. 362 // Search section.
357 $('manage-default-search-engines').onclick = function(event) { 363 $('manage-default-search-engines').onclick = function(event) {
358 PageManager.showPageByName('searchEngines'); 364 PageManager.showPageByName('searchEngines');
359 chrome.send('coreOptionsUserMetricsAction', 365 chrome.send('coreOptionsUserMetricsAction',
360 ['Options_ManageSearchEngines']); 366 ['Options_ManageSearchEngines']);
361 }; 367 };
362 $('default-search-engine').addEventListener('change', 368 $('default-search-engine').addEventListener('change',
363 this.setDefaultSearchEngine_); 369 this.setDefaultSearchEngine_);
(...skipping 2046 matching lines...) Expand 10 before | Expand all | Expand 10 after
2410 if (section) 2416 if (section)
2411 section.hidden = false; 2417 section.hidden = false;
2412 }; 2418 };
2413 } 2419 }
2414 2420
2415 // Export 2421 // Export
2416 return { 2422 return {
2417 BrowserOptions: BrowserOptions 2423 BrowserOptions: BrowserOptions
2418 }; 2424 };
2419 }); 2425 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/browser_options.html ('k') | chrome/browser/resources/options/chromeos/storage_manager.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698