Add storage manager overlay on Settings.

Add storage manager overlay on Settings.

This CL adds a button for storage manager overlay in Setting page's device section.
The button is shown only when the flag --enable-storage-manager is specified.
The content of the overlay is empty for now.
I'm going to add functions on top of it.

BUG=591958
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872
Cr-Commit-Position: refs/heads/master@{#396136}

[fukino, 2016-05-24 14:49:13]

Description was changed from

==========
Add storage manager overlay on Settings.

BUG=591958
==========

to

==========
Add storage manager overlay on Settings.

BUG=591958
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-05-24 14:59:13]

Description was changed from

==========
Add storage manager overlay on Settings.

BUG=591958
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Add storage manager overlay on Settings.

This CL adds a button for storage manager overlay in Setting page's device
section.
The button is shown only when the flag --enable-storage-manager is specified.
The content of the overlay is empty for now.
I'm going to add functions on top of it.

BUG=591958
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-05-24 16:01:40]

fukino@chromium.org changed reviewers:
+ dbeam@chromium.org, mpearson@chromium.org

[fukino, 2016-05-24 16:01:41]

dbeam@,
This CL adds an overlay for storage manager behind a flag.
Could you review this?

mpearson@,
Could you review histogram.xml?

Thanks!

[Mark P, 2016-05-24 19:53:18]

histograms.xml lgtm

[Dan Beam, 2016-05-26 00:10:37]

lgtm

https://codereview.chromium.org/2009543002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/options/chromeos/storage_manager.html (right):

https://codereview.chromium.org/2009543002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/storage_manager.html:3:
<h1>Storage</h1>
this needs a translation

https://codereview.chromium.org/2009543002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/2009543002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/browser_options_handler.cc:740:
values->SetBoolean("enableStorageManager",
nit:

values->SetBoolean("enableStorageManager",
    base::CommandLine::ForCurrentProcess()->HasSwitch(
        chromeos::switches::kEnableStorageManager));

[Dan Beam, 2016-05-26 00:11:22]

i should re-emphasize again, though, that Material Design settings is coming as
soon as possible.  we're really hoping in the next 1-3 milestones, but it really
depends...

[fukino, 2016-05-26 04:54:54]

Thank you!

https://codereview.chromium.org/2009543002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/options/chromeos/storage_manager.html (right):

https://codereview.chromium.org/2009543002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/storage_manager.html:3:
<h1>Storage</h1>
On 2016/05/26 00:10:37, Dan Beam wrote:
> this needs a translation

Done.

https://codereview.chromium.org/2009543002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/2009543002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/browser_options_handler.cc:740:
values->SetBoolean("enableStorageManager",
On 2016/05/26 00:10:37, Dan Beam wrote:
> nit:
> 
> values->SetBoolean("enableStorageManager",
>     base::CommandLine::ForCurrentProcess()->HasSwitch(
>         chromeos::switches::kEnableStorageManager));

Done.

[fukino, 2016-05-26 05:00:26]

On 2016/05/26 00:11:22, Dan Beam wrote:
> i should re-emphasize again, though, that Material Design settings is coming
as
> soon as possible.  we're really hoping in the next 1-3 milestones, but it
really
> depends...

Yes, our UX started working on a mock for storage manager in MD settings.
Please let us know when you get updates about the schedule!

[fukino, 2016-05-26 05:00:34]

The CQ bit was checked by fukino@chromium.org

[fukino, 2016-05-26 05:00:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2009543002/#ps40001
(title: "Address review comments")

[commit-bot: I haz the power, 2016-05-26 05:00:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009543002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009543002/40001

[commit-bot: I haz the power, 2016-05-26 06:56:48]

Description was changed from

==========
Add storage manager overlay on Settings.

This CL adds a button for storage manager overlay in Setting page's device
section.
The button is shown only when the flag --enable-storage-manager is specified.
The content of the overlay is empty for now.
I'm going to add functions on top of it.

BUG=591958
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Add storage manager overlay on Settings.

This CL adds a button for storage manager overlay in Setting page's device
section.
The button is shown only when the flag --enable-storage-manager is specified.
The content of the overlay is empty for now.
I'm going to add functions on top of it.

BUG=591958
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-26 06:56:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-26 06:58:52]

Description was changed from

==========
Add storage manager overlay on Settings.

This CL adds a button for storage manager overlay in Setting page's device
section.
The button is shown only when the flag --enable-storage-manager is specified.
The content of the overlay is empty for now.
I'm going to add functions on top of it.

BUG=591958
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Add storage manager overlay on Settings.

This CL adds a button for storage manager overlay in Setting page's device
section.
The button is shown only when the flag --enable-storage-manager is specified.
The content of the overlay is empty for now.
I'm going to add functions on top of it.

BUG=591958
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872
Cr-Commit-Position: refs/heads/master@{#396136}
==========

[commit-bot: I haz the power, 2016-05-26 06:58:53]

Patchset 3 (id:??) landed as
https://crrev.com/0063cf80ae18f025807016c41f17462d51bee872
Cr-Commit-Position: refs/heads/master@{#396136}