Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2009513002: Avoid leaking objects that should be collected after tree-shaking. (Closed)

Created:
4 years, 7 months ago by Florian Schneider
Modified:
4 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid leaking objects that should be collected after tree-shaking. Added handle scopes to ensure that no objects leak through handles to after tree-shaking where we expect no instances of dropped classes being around. BUG=dartbug.com/26515 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/3344a6f6f437757cfc2f5306ffde23e645c266e9

Patch Set 1 #

Patch Set 2 : no indent #

Patch Set 3 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -51 lines) Patch
M runtime/vm/precompiler.cc View 1 2 2 chunks +54 lines, -51 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
rmacnak
LGTM
4 years, 7 months ago (2016-05-24 19:53:42 UTC) #3
Florian Schneider
4 years, 6 months ago (2016-05-25 14:15:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
3344a6f6f437757cfc2f5306ffde23e645c266e9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698