Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2009503004: Added strings for notification when user presses backspace. (Closed)

Created:
4 years, 7 months ago by Matt Giuca
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Added strings for notification when user presses backspace. These will be used in a future CL (https://codereview.chromium.org/1983803002). The strings are being checked in early to ensure they are in before branch point. Notry rationale: Tree is broken due to https://crbug.com/613258. All other tests have passed on trybots. BUG=610039 NOTRY=true Review-Url: https://codereview.chromium.org/1995893002 Cr-Commit-Position: refs/heads/master@{#394968} (cherry picked from commit 8386be414ec1537ad2c033889996f2419b330c42) Committed: https://chromium.googlesource.com/chromium/src/+/38619b874e6aaeb1765a4b41943cd7171179ef97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/strings/ui_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Matt Giuca
4 years, 7 months ago (2016-05-25 03:45:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
38619b874e6aaeb1765a4b41943cd7171179ef97.

Powered by Google App Engine
This is Rietveld 408576698