Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2009483002: Remove WebMemoryDumpProvider (Closed)

Created:
4 years, 7 months ago by bashi
Modified:
4 years, 7 months ago
CC:
Mads Ager (chromium), blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, feature-media-reviews_chromium.org, gavinp+loader_chromium.org, jam, Nate Chapin, jochen+watch_chromium.org, kinuko+watch, kouhei+heap_chromium.org, loading-reviews+fetch_chromium.org, mlamouri+watch-test-runner_chromium.org, oilpan-reviews, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebMemoryDumpProvider BUG=605822 Committed: https://crrev.com/337a3fc4f1a26274585d52ac52beab41a0dfd6dc Cr-Commit-Position: refs/heads/master@{#396135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -236 lines) Patch
M components/test_runner/test_common.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/run_all_unittests.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/MemoryCacheDumpProvider.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/Platform.cpp View 3 chunks +0 lines, -41 lines 0 comments Download
D third_party/WebKit/Source/platform/exported/WebMemoryDumpProvider.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/platform/web_memory_dump_provider_adapter.h View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/Source/platform/web_memory_dump_provider_adapter.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 2 chunks +0 lines, -11 lines 0 comments Download
D third_party/WebKit/public/platform/WebMemoryDumpProvider.h View 1 chunk +0 lines, -57 lines 0 comments Download
M third_party/WebKit/public/platform/WebProcessMemoryDump.h View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
bashi
PTAL? dpranke@ for components/test_runner esprehn@ for content/child ddorwin@ for media/ haraken@ for third_party/WebKit
4 years, 7 months ago (2016-05-24 11:18:43 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-24 14:00:51 UTC) #3
esprehn
lgtm
4 years, 7 months ago (2016-05-24 16:19:25 UTC) #4
ddorwin
media/ lgtm
4 years, 7 months ago (2016-05-24 18:42:13 UTC) #5
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-24 18:53:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009483002/1
4 years, 7 months ago (2016-05-25 23:37:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/235739)
4 years, 7 months ago (2016-05-26 03:17:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009483002/1
4 years, 7 months ago (2016-05-26 04:49:18 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 06:39:45 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 06:41:03 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/337a3fc4f1a26274585d52ac52beab41a0dfd6dc
Cr-Commit-Position: refs/heads/master@{#396135}

Powered by Google App Engine
This is Rietveld 408576698