content/browser/service_worker/service_worker_browsertest.cc - Issue 2009453002: service worker: Don't control a subframe of an insecure context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 2009453002: service worker: Don't control a subframe of an insecure context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: refactor errorMessage Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/service_worker_apitest.cc ('k') | content/browser/service_worker/service_worker_context_core.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_browsertest.cc

diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc

index 60c6b2bad01ea5e7e20668f906df300a31826a29..21cdf65261cce967fb725dd0934d0c18580c3e7f 100644

--- a/content/browser/service_worker/service_worker_browsertest.cc

+++ b/content/browser/service_worker/service_worker_browsertest.cc

@@ -528,11 +528,12 @@ class ServiceWorkerVersionBrowserTest : public ServiceWorkerBrowserTest {

void AddControlleeOnIOThread() {

ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));

std::unique_ptr<ServiceWorkerProviderHost> host(

- new ServiceWorkerProviderHost(33 /* dummy render process id */,

- MSG_ROUTING_NONE /* render_frame_id */,

- 1 /* dummy provider_id */,

- SERVICE_WORKER_PROVIDER_FOR_WINDOW,

- wrapper()->context()->AsWeakPtr(), NULL));

+ new ServiceWorkerProviderHost(

+ 33 /* dummy render process id */,

+ MSG_ROUTING_NONE /* render_frame_id */, 1 /* dummy provider_id */,

+ SERVICE_WORKER_PROVIDER_FOR_WINDOW,

+ ServiceWorkerProviderHost::FrameSecurityLevel::SECURE,

+ wrapper()->context()->AsWeakPtr(), NULL));

host->SetDocumentUrl(

embedded_test_server()->GetURL("/service_worker/host"));

host->AssociateRegistration(registration_.get(),