Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: third_party/WebKit/public/web/WebFrame.h

Issue 2009453002: service worker: Don't control a subframe of an insecure context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: consolidate tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebFrame.h
diff --git a/third_party/WebKit/public/web/WebFrame.h b/third_party/WebKit/public/web/WebFrame.h
index 121067b357c1273235e7b42cb559f7c136458313..33d7a80e9715dc2e72d5babd53f1d967872206d0 100644
--- a/third_party/WebKit/public/web/WebFrame.h
+++ b/third_party/WebKit/public/web/WebFrame.h
@@ -556,6 +556,15 @@ public:
// the given element is not a frame, iframe or if the frame is empty.
BLINK_EXPORT static WebFrame* fromFrameOwnerElement(const WebElement&);
+ // Use WebDocument::isSecureContext() instead of this function to
+ // check whether a context is secure.
kinuko 2016/06/06 06:43:16 nit: the term 'context' is pretty vague in general
falken 2016/06/06 06:56:55 Yes I think there's some inconsistency here. Did s
+ //
+ // Returns whether it's possible for a descendant of this frame to be a
+ // secure context, not considering scheme exceptions (since any
+ // descendant can be a secure context if it has a scheme exception).
+ // See Document::isSecureContextImpl for more details.
+ BLINK_EXPORT bool canHaveSecureChild() const;
+
#if BLINK_IMPLEMENTATION
static WebFrame* fromFrame(Frame*);

Powered by Google App Engine
This is Rietveld 408576698