third_party/WebKit/Source/web/WebFrame.cpp - Issue 2009453002: service worker: Don't control a subframe of an insecure context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrame.cpp

Issue 2009453002: service worker: Don't control a subframe of an insecure context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/content_browser_client.h ('K') | « third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebFrame.cpp

diff --git a/third_party/WebKit/Source/web/WebFrame.cpp b/third_party/WebKit/Source/web/WebFrame.cpp

index 1c4b5b4cce46d5568969978b2dec78a3d8687ee9..607a2e454e2fa36af4830e0503abe7b2c940d9e5 100644

--- a/third_party/WebKit/Source/web/WebFrame.cpp

+++ b/third_party/WebKit/Source/web/WebFrame.cpp

@@ -285,6 +285,16 @@ WebFrame* WebFrame::fromFrameOwnerElement(const WebElement& webElement)

return fromFrame(toHTMLFrameOwnerElement(element)->contentFrame());

}

+bool WebFrame::canHaveSecureChild() const

+ Frame* frame = toImplBase()->frame();

+ if (!frame)

+ return false;

+ String message;

+ bool result = frame->canHaveSecureChild(&message);

+ return result;

horo 2016/06/03 09:54:45 nit: we don't need `result` variable.

falken 2016/06/03 12:10:45 Done.

bool WebFrame::isLoading() const

{

if (Frame* frame = toImplBase()->frame())