Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Unified Diff: content/browser/service_worker/service_worker_version_unittest.cc

Issue 2009453002: service worker: Don't control a subframe of an insecure context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version_unittest.cc
diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc
index 000eb26eee486f03b3f405b07086bc8f35f9b8d3..ed7d5955d14b4926e54d4298b4ca9f1c49b7e17c 100644
--- a/content/browser/service_worker/service_worker_version_unittest.cc
+++ b/content/browser/service_worker/service_worker_version_unittest.cc
@@ -621,7 +621,8 @@ TEST_F(ServiceWorkerVersionTest, IdleTimeout) {
std::unique_ptr<ServiceWorkerProviderHost> host(new ServiceWorkerProviderHost(
33 /* dummy render process id */, MSG_ROUTING_NONE /* render_frame_id */,
1 /* dummy provider_id */, SERVICE_WORKER_PROVIDER_FOR_WINDOW,
- helper_->context()->AsWeakPtr(), NULL));
+ true /* is_parent_frame_secure */, helper_->context()->AsWeakPtr(),
+ NULL));
version_->AddControllee(host.get());
EXPECT_TRUE(version_->timeout_timer_.IsRunning());
EXPECT_LT(idle_time, version_->idle_time_);

Powered by Google App Engine
This is Rietveld 408576698