Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2114)

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 2009453002: service worker: Don't control a subframe of an insecure context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: selfreview Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_provider_host.cc
diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc
index 21e0ddf6239ab50140f37c2ac4180f613cd2beca..4669d335e86d608d750e5ea5fcaf268f45d1ffd1 100644
--- a/content/browser/service_worker/service_worker_provider_host.cc
+++ b/content/browser/service_worker/service_worker_provider_host.cc
@@ -54,7 +54,7 @@ ServiceWorkerProviderHost::PreCreateNavigationHost(
return std::unique_ptr<ServiceWorkerProviderHost>(
new ServiceWorkerProviderHost(
ChildProcessHost::kInvalidUniqueID, MSG_ROUTING_NONE, provider_id,
- SERVICE_WORKER_PROVIDER_FOR_WINDOW, context, nullptr));
+ SERVICE_WORKER_PROVIDER_FOR_WINDOW, false, context, nullptr));
}
ServiceWorkerProviderHost::ServiceWorkerProviderHost(
@@ -62,6 +62,7 @@ ServiceWorkerProviderHost::ServiceWorkerProviderHost(
int route_id,
int provider_id,
ServiceWorkerProviderType provider_type,
+ bool is_parent_frame_secure,
base::WeakPtr<ServiceWorkerContextCore> context,
ServiceWorkerDispatcherHost* dispatcher_host)
: client_uuid_(base::GenerateGUID()),
@@ -70,6 +71,7 @@ ServiceWorkerProviderHost::ServiceWorkerProviderHost(
render_thread_id_(kDocumentMainThreadId),
provider_id_(provider_id),
provider_type_(provider_type),
+ is_parent_frame_secure_(is_parent_frame_secure),
context_(context),
dispatcher_host_(dispatcher_host),
allow_association_(true) {

Powered by Google App Engine
This is Rietveld 408576698