content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc - Issue 2009453002: service worker: Don't control a subframe of an insecure context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc

Issue 2009453002: service worker: Don't control a subframe of an insecure context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: selfreview Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_controllee_request_handler.cc ('K') | « content/browser/service_worker/service_worker_controllee_request_handler.cc ('k') | content/browser/service_worker/service_worker_dispatcher_host.h » ('j') | content/browser/service_worker/service_worker_request_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc

diff --git a/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc b/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc

index c31d4ba80ae561433f8cdb5090472816a7b01961..5177f790eda945797911752768277abb041f9c34 100644

--- a/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc

+++ b/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc

@@ -119,10 +119,10 @@ class ServiceWorkerControlleeRequestHandlerTest : public testing::Test {

// An empty host.

std::unique_ptr<ServiceWorkerProviderHost> host(

- new ServiceWorkerProviderHost(helper_->mock_render_process_id(),

- MSG_ROUTING_NONE, kMockProviderId,

- SERVICE_WORKER_PROVIDER_FOR_WINDOW,

- context()->AsWeakPtr(), NULL));

+ new ServiceWorkerProviderHost(

+ helper_->mock_render_process_id(), MSG_ROUTING_NONE,

+ kMockProviderId, SERVICE_WORKER_PROVIDER_FOR_WINDOW,

+ true /* is_parent_frame_secure */, context()->AsWeakPtr(), NULL));

provider_host_ = host->AsWeakPtr();

context()->AddProviderHost(std::move(host));