content/child/service_worker/service_worker_network_provider.h - Issue 2009453002: service worker: Don't control a subframe of an insecure context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/service_worker_network_provider.h

Issue 2009453002: service worker: Don't control a subframe of an insecure context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: getSecurityOrigin Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_request.cc ('K') | « content/browser/frame_host/navigation_request.cc ('k') | content/child/service_worker/service_worker_network_provider.cc » ('j') | content/child/service_worker/service_worker_network_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/service_worker_network_provider.h

diff --git a/content/child/service_worker/service_worker_network_provider.h b/content/child/service_worker/service_worker_network_provider.h

index 178adf5a1ceca4d0c48dc2d58a71f7590cb04e3e..e679616dd3cfba0c0fd9ecccf1e9d4ff5a6423a0 100644

--- a/content/child/service_worker/service_worker_network_provider.h

+++ b/content/child/service_worker/service_worker_network_provider.h

@@ -15,7 +15,10 @@

#include "base/supports_user_data.h"

#include "content/common/content_export.h"

#include "content/common/service_worker/service_worker_types.h"

-#include "third_party/WebKit/public/web/WebSandboxFlags.h"

+namespace blink {

+class WebLocalFrame;

jww 2016/05/24 18:06:03 nit: " // namespace blink"

falken 2016/05/25 09:19:58 Done.

namespace content {

@@ -46,7 +49,7 @@ class CONTENT_EXPORT ServiceWorkerNetworkProvider

static std::unique_ptr<ServiceWorkerNetworkProvider> CreateForNavigation(

int route_id,

const RequestNavigationParams& request_params,

- blink::WebSandboxFlags sandbox_flags,

+ blink::WebLocalFrame* frame,

bool content_initiated);

// PlzNavigate