Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: third_party/WebKit/Source/web/WebFrame.cpp

Issue 2009453002: service worker: Don't control a subframe of an insecure context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cover plznavigation case too Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebFrame.cpp
diff --git a/third_party/WebKit/Source/web/WebFrame.cpp b/third_party/WebKit/Source/web/WebFrame.cpp
index a65d50dcad1a89989d68feae3c674e1513e315df..acd9007714eefb0ef85ebf93b0fe7930187b328a 100644
--- a/third_party/WebKit/Source/web/WebFrame.cpp
+++ b/third_party/WebKit/Source/web/WebFrame.cpp
@@ -273,6 +273,17 @@ WebFrame* WebFrame::fromFrameOwnerElement(const WebElement& webElement)
return fromFrame(toHTMLFrameOwnerElement(element)->contentFrame());
}
+bool WebFrame::canHaveSecureChild(WebString& errorMessage) const
jww 2016/05/28 01:35:25 Can you add some unit tests to this, similar to wh
falken 2016/05/30 10:20:53 Didn't get to this in the latest patchset, but wil
+{
+ Frame* frame = toImplBase()->frame();
+ if (!frame)
+ return false;
+ String message;
+ bool result = frame->canHaveSecureChild(&message);
+ errorMessage = message;
+ return result;
+}
+
bool WebFrame::isLoading() const
{
if (Frame* frame = toImplBase()->frame())

Powered by Google App Engine
This is Rietveld 408576698