MD Settings: fix settings-dialog (X) close button styles to match spec

MD Settings: fix settings-dialog (X) close button styles to match spec

BUG=595804
R=dpapad@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8a8aadddb9e4b863f28c9d417310eb24eb716d48
Cr-Commit-Position: refs/heads/master@{#396045}

[Dan Beam, 2016-05-25 21:52:20]

Description was changed from

==========
MD Settings: fix settings-dialog (X) close button styles to match spec

BUG=595804
R=dpapad@chromium.org
==========

to

==========
MD Settings: fix settings-dialog (X) close button styles to match spec

BUG=595804
R=dpapad@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-05-25 21:53:55]

here's where <paper-icon-button> overrides --iron-icon-{height,width}

https://github.com/PolymerElements/paper-icon-button/blob/master/paper-icon-b...

[Dan Beam, 2016-05-25 21:55:35]

also, screenshot here:
https://bugs.chromium.org/p/chromium/issues/detail?id=595804#c23

[dpapad, 2016-05-25 22:00:49]

On 2016/05/25 at 21:55:35, dbeam wrote:
> also, screenshot here:
https://bugs.chromium.org/p/chromium/issues/detail?id=595804#c23

LGTM. Does the ripple effect finish animating before the iron-overlay-closed
event fires? Asking because
if we care enough about this ripple, we should ensure that the user has time to
see the ripple before
closing the dialog. In many occasasions we remove the dialog from the DOM inside
the iron-overly-closed
listener.

[Dan Beam, 2016-05-25 22:02:21]

On 2016/05/25 22:00:49, dpapad wrote:
> On 2016/05/25 at 21:55:35, dbeam wrote:
> > also, screenshot here:
> https://bugs.chromium.org/p/chromium/issues/detail?id=595804#c23
> 
> LGTM. Does the ripple effect finish animating before the iron-overlay-closed
> event fires? Asking because
> if we care enough about this ripple, we should ensure that the user has time
to
> see the ripple before
> closing the dialog. In many occasasions we remove the dialog from the DOM
inside
> the iron-overly-closed
> listener.

nah, I don't care about showing the ripple if the dialog should close

[Dan Beam, 2016-05-25 22:03:16]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-05-25 22:03:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009383003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009383003/1

[commit-bot: I haz the power, 2016-05-25 22:54:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 22:54:53]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2016-05-25 22:55:36]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-05-25 22:56:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009383003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009383003/1

[commit-bot: I haz the power, 2016-05-25 23:52:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-25 23:53:29]

Description was changed from

==========
MD Settings: fix settings-dialog (X) close button styles to match spec

BUG=595804
R=dpapad@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: fix settings-dialog (X) close button styles to match spec

BUG=595804
R=dpapad@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8a8aadddb9e4b863f28c9d417310eb24eb716d48
Cr-Commit-Position: refs/heads/master@{#396045}
==========

[commit-bot: I haz the power, 2016-05-25 23:53:30]

Patchset 1 (id:??) landed as
https://crrev.com/8a8aadddb9e4b863f28c9d417310eb24eb716d48
Cr-Commit-Position: refs/heads/master@{#396045}