Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2009383003: MD Settings: fix settings-dialog (X) close button styles to match spec (Closed)

Created:
4 years, 7 months ago by Dan Beam
Modified:
4 years, 7 months ago
Reviewers:
dpapad
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix settings-dialog (X) close button styles to match spec BUG=595804 R=dpapad@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8a8aadddb9e4b863f28c9d417310eb24eb716d48 Cr-Commit-Position: refs/heads/master@{#396045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M chrome/browser/resources/settings/settings_dialog.html View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Dan Beam
4 years, 7 months ago (2016-05-25 21:53:13 UTC) #2
Dan Beam
here's where <paper-icon-button> overrides --iron-icon-{height,width} https://github.com/PolymerElements/paper-icon-button/blob/master/paper-icon-button.html#L115-116
4 years, 7 months ago (2016-05-25 21:53:55 UTC) #3
Dan Beam
also, screenshot here: https://bugs.chromium.org/p/chromium/issues/detail?id=595804#c23
4 years, 7 months ago (2016-05-25 21:55:35 UTC) #4
dpapad
On 2016/05/25 at 21:55:35, dbeam wrote: > also, screenshot here: https://bugs.chromium.org/p/chromium/issues/detail?id=595804#c23 LGTM. Does the ripple ...
4 years, 7 months ago (2016-05-25 22:00:49 UTC) #5
Dan Beam
On 2016/05/25 22:00:49, dpapad wrote: > On 2016/05/25 at 21:55:35, dbeam wrote: > > also, ...
4 years, 7 months ago (2016-05-25 22:02:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009383003/1
4 years, 7 months ago (2016-05-25 22:03:58 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/235632)
4 years, 7 months ago (2016-05-25 22:54:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009383003/1
4 years, 7 months ago (2016-05-25 22:56:44 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 23:52:33 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 23:53:30 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a8aadddb9e4b863f28c9d417310eb24eb716d48
Cr-Commit-Position: refs/heads/master@{#396045}

Powered by Google App Engine
This is Rietveld 408576698