Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2009383002: Reland of "[heap] Fine-grained JSArrayBuffer tracking" (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "[heap] Fine-grained JSArrayBuffer tracking" (patchset #1 id:1 of https://codereview.chromium.org/2011563003/ ) Reason for revert: Premature revert. Chromium roll included an earlier version. Original issue's description: > Revert of "[heap] Fine-grained JSArrayBuffer tracking" (patchset #3 id:80001 of https://codereview.chromium.org/2007253002/ ) > > Reason for revert: > Breaks webgl2 conformance tests > https://bugs.chromium.org/p/chromium/issues/detail?id=614730 > > Original issue's description: > > Reland of "[heap] Fine-grained JSArrayBuffer tracking" > > > > Track based on JSArrayBuffer addresses on pages instead of the attached > > backing store. > > > > Details of tracking: > > - Scavenge: New space pages are processes in bulk on the main thread > > - MC: Unswept pages are processed in bulk in parallel. All other pages > > are processed by the sweeper concurrently. > > > > This reverts commit 93fe04afa9428f4f68dc5dd302cda83908be84a7. > > > > R=hpayer@chromium.org > > BUG=chromium:611688 > > LOG=N > > CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel > > > > Committed: https://crrev.com/863d015e573798e263b35b31d2ab979739706533 > > Cr-Commit-Position: refs/heads/master@{#36513} > > TBR=hpayer@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:611688 > > Committed: https://crrev.com/b9b0868ec49a52c9a80c9beea862a61707b292e5 > Cr-Commit-Position: refs/heads/master@{#36524} TBR=hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:611688 Committed: https://crrev.com/b23e008885c4c452ae2b329c9dad167a76e4d7be Cr-Commit-Position: refs/heads/master@{#36530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+598 lines, -160 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/array-buffer-tracker.h View 1 chunk +87 lines, -36 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 2 chunks +132 lines, -86 lines 0 comments Download
A src/heap/array-buffer-tracker-inl.h View 1 chunk +74 lines, -0 lines 0 comments Download
M src/heap/heap.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 8 chunks +20 lines, -18 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/heap/spaces.h View 6 chunks +32 lines, -1 line 0 comments Download
M src/heap/spaces.cc View 3 chunks +10 lines, -1 line 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/heap-utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 chunk +15 lines, -0 lines 0 comments Download
A test/cctest/heap/test-array-buffer-tracker.cc View 1 chunk +206 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Lippautz
Created Reland of "[heap] Fine-grained JSArrayBuffer tracking"
4 years, 7 months ago (2016-05-25 21:06:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009383002/1
4 years, 7 months ago (2016-05-25 21:06:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 21:07:05 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b23e008885c4c452ae2b329c9dad167a76e4d7be Cr-Commit-Position: refs/heads/master@{#36530}
4 years, 7 months ago (2016-05-25 21:09:36 UTC) #5
Michael Lippautz
4 years, 7 months ago (2016-05-25 21:20:26 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2009893003/ by mlippautz@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Debug%20%28NVI....

Powered by Google App Engine
This is Rietveld 408576698