Converts Widget::SetOpacity from char to float

Converts Widget::SetOpacity from char to float

This better matches what we do every where.

BUG=none
TEST=none
R=ben@chromium.org

Committed: https://crrev.com/8b858455d0b6ef5155103a0c91956ee259813391
Cr-Commit-Position: refs/heads/master@{#395980}

[Ben Goodger (Google), 2016-05-25 20:23:41]

lgtm

[sky, 2016-05-25 20:28:50]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-05-25 20:29:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009333002/1

[commit-bot: I haz the power, 2016-05-25 20:36:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-25 20:38:26]

Description was changed from

==========
Converts Widget::SetOpacity from char to float

This better matches what we do every where.

BUG=none
TEST=none
R=ben@chromium.org
==========

to

==========
Converts Widget::SetOpacity from char to float

This better matches what we do every where.

BUG=none
TEST=none
R=ben@chromium.org

Committed: https://crrev.com/8b858455d0b6ef5155103a0c91956ee259813391
Cr-Commit-Position: refs/heads/master@{#395980}
==========

[commit-bot: I haz the power, 2016-05-25 20:38:27]

Patchset 1 (id:??) landed as
https://crrev.com/8b858455d0b6ef5155103a0c91956ee259813391
Cr-Commit-Position: refs/heads/master@{#395980}

[Peter Kasting, 2016-05-27 06:00:58]

This seems to have missed a whole bunch of callsites, which will produce bad
effects (since calling Widget::SetOpacity() with a value greater than 1 will
result in strange graphic problems like drawing solid white).

I'm trying to fix these in https://codereview.chromium.org/2016203002 , but that
will only catch things that trigger the DCHECKs I'm adding when run on the
trybots.  Please consider re-auditing everything that could call any of these
functions, and adding tests to catch any places I've missed.

[sky, 2016-05-27 15:18:54]

Implicit conversion suxs. I will take another look this morning.

  -Scott

On Thu, May 26, 2016 at 11:00 PM,  <pkasting@chromium.org> wrote:
> This seems to have missed a whole bunch of callsites, which will produce bad
> effects (since calling Widget::SetOpacity() with a value greater than 1 will
> result in strange graphic problems like drawing solid white).
>
> I'm trying to fix these in https://codereview.chromium.org/2016203002 , but
> that
> will only catch things that trigger the DCHECKs I'm adding when run on the
> trybots. Please consider re-auditing everything that could call any of these
> functions, and adding tests to catch any places I've missed.
>
> https://codereview.chromium.org/2009333002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.