Embedder support refactoring (phase 1).

Embedder support refactoring (phase 1).

A bunch of changes to pave the way for emebdder SDK summary creation.

* Moves _embedder.yaml processing into the embedder SDK (out of the resolver).
* Changes EmbedderUriResolver to compose rather than extend a DartUriResolver.
* Fixes the wierd handling (dropping to add back) of `dart:` URIs.
* Fixes the incorrect overriding docs for `SDKLibraryImpl.shortName`.
* Updates embedder test to include a definition of `dart:core` in anticipation of adding some embedder SDK tests.

Some API work TODO in a follow-up CL (notably the way we check for the presence of embedders by querying the resolver is odd).

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/53fe39137fb7601d2ea3596a8a6407815c383e8f

[pquitslund, 2016-05-25 17:29:09]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-05-25 17:45:57]

lgtm

https://codereview.chromium.org/2009303002/diff/1/pkg/analyzer/test/source/em...
File pkg/analyzer/test/source/embedder_test.dart (right):

https://codereview.chromium.org/2009303002/diff/1/pkg/analyzer/test/source/em...
pkg/analyzer/test/source/embedder_test.dart:53: expect(resolver.length, 5);
Seems strange, if there are five mappings, that we're only testing four of them
below.

[pquitslund, 2016-05-25 17:52:00]

Thanks!

https://codereview.chromium.org/2009303002/diff/1/pkg/analyzer/test/source/em...
File pkg/analyzer/test/source/embedder_test.dart (right):

https://codereview.chromium.org/2009303002/diff/1/pkg/analyzer/test/source/em...
pkg/analyzer/test/source/embedder_test.dart:53: expect(resolver.length, 5);
On 2016/05/25 17:45:56, Brian Wilkerson wrote:
> Seems strange, if there are five mappings, that we're only testing four of
them
> below.

Indeed!  Forgot to update that bit.  Fixed.

[pquitslund, 2016-05-25 17:52:59]

Description was changed from

==========
Embedder support refactoring (phase 1).

A bunch of changes to pave the way for emebdder SDK summary creation.

* Moves _embedder.yaml processing into the embedder SDK (out of the resolver).
* Changes EmbedderUriResolver to compose rather than extend a DartUriResolver.
* Fixes the wierd handling (dropping to add back) of `dart:` URIs.
* Fixes the incorrect overriding docs for `SDKLibraryImpl.shortName`.
* Updates embedder test to include a definition of `dart:core` in anticipation
of adding some embedder SDK tests.

Some API work TODO in a follow-up CL (notably the way we check for the presence
of embedders by querying the resolver is odd).

BUG=
==========

to

==========
Embedder support refactoring (phase 1).

A bunch of changes to pave the way for emebdder SDK summary creation.

* Moves _embedder.yaml processing into the embedder SDK (out of the resolver).
* Changes EmbedderUriResolver to compose rather than extend a DartUriResolver.
* Fixes the wierd handling (dropping to add back) of `dart:` URIs.
* Fixes the incorrect overriding docs for `SDKLibraryImpl.shortName`.
* Updates embedder test to include a definition of `dart:core` in anticipation
of adding some embedder SDK tests.

Some API work TODO in a follow-up CL (notably the way we check for the presence
of embedders by querying the resolver is odd).

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/53fe39137fb7601d2ea3596a8a6407815c383e8f
==========

[pquitslund, 2016-05-25 17:53:00]

Committed patchset #1 (id:1) manually as
53fe39137fb7601d2ea3596a8a6407815c383e8f (presubmit successful).

[pquitslund, 2016-05-25 18:53:13]

FYI @danrubel: in case this has any impact on fletch...