[css3-text] Minor fixes on CSSParser for text-decoration

[css3-text] Minor fixes on CSSParser for text-decoration

Fixed an issue that prevents an invalid access for CSS parsed values.
This fix also prepares the terrain for the upcoming text-decoration
shorthand implementation.

BUG=165462
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154847

[abinader, 2013-07-24 19:45:11]

On 2013/07/24 19:09:20, abinader wrote:

Ugh, trybots are obtaining non-related layout test failures... probably
NOTRY=true shall be needed in this case.

[Julien - ping for review, 2013-07-24 20:57:28]

lgtm

https://codereview.chromium.org/20093008/diff/1/Source/core/css/CSSParser-in.cpp
File Source/core/css/CSSParser-in.cpp (right):

https://codereview.chromium.org/20093008/diff/1/Source/core/css/CSSParser-in....
Source/core/css/CSSParser-in.cpp:8788: if (value && value->id == CSSValueNone) {
As said on IRC, it would have been better to keep this NULL-check for the
follow-up change where it matters.

[abinader, 2013-07-24 21:02:02]

On 2013/07/24 20:57:28, Julien Chaffraix wrote:
> lgtm
> 
>
https://codereview.chromium.org/20093008/diff/1/Source/core/css/CSSParser-in.cpp
> File Source/core/css/CSSParser-in.cpp (right):
> 
>
https://codereview.chromium.org/20093008/diff/1/Source/core/css/CSSParser-in....
> Source/core/css/CSSParser-in.cpp:8788: if (value && value->id == CSSValueNone)
{
> As said on IRC, it would have been better to keep this NULL-check for the
> follow-up change where it matters.

Ack, I'll keep that in mind for the next patches to come, thanks Julien!

[commit-bot: I haz the power, 2013-07-24 21:08:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bruno.d@partner.samsung.com/20093008/1

[commit-bot: I haz the power, 2013-07-24 21:15:34]

Change committed as 154847