Cleanup: Pass std::string as const reference from tools/clang/

Cleanup: Pass std::string as const reference from tools/clang/

Passing std::string by reference can prevent extra copying of object.

BUG=367418
TEST=
R=thakis@chromium.org,hans@chromium.org

Committed: https://crrev.com/1ccf0063582e4e727cf89835d12b5c213f7b83d2
Cr-Commit-Position: refs/heads/master@{#395945}

[hans, 2016-05-25 17:31:25]

https://codereview.chromium.org/2009293002/diff/1/tools/clang/empty_string/te...
File tools/clang/empty_string/tests/test-original.cc (right):

https://codereview.chromium.org/2009293002/diff/1/tools/clang/empty_string/te...
tools/clang/empty_string/tests/test-original.cc:35: const std::string&
value_argument) {
This file is a test case for the plugin, it's not actually code that we run, so
it shouldn't be changed.

Also note that the name of this parameter suggests it should be passed by value
rather than reference :-)

[ki.stfu, 2016-05-25 17:37:58]

https://codereview.chromium.org/2009293002/diff/1/tools/clang/empty_string/te...
File tools/clang/empty_string/tests/test-original.cc (right):

https://codereview.chromium.org/2009293002/diff/1/tools/clang/empty_string/te...
tools/clang/empty_string/tests/test-original.cc:35: const std::string&
value_argument) {
On 2016/05/25 17:31:25, hans wrote:
> This file is a test case for the plugin, it's not actually code that we run,
so
> it shouldn't be changed.
> 
> Also note that the name of this parameter suggests it should be passed by
value
> rather than reference :-)

Thanks for very quick response!

[hans, 2016-05-25 17:45:58]

https://codereview.chromium.org/2009293002/diff/20001/tools/clang/blink_gc_pl...
File tools/clang/blink_gc_plugin/JsonWriter.h (right):

https://codereview.chromium.org/2009293002/diff/20001/tools/clang/blink_gc_pl...
tools/clang/blink_gc_plugin/JsonWriter.h:51: void Write(const std::string& key,
const std::string val) {
Should probably pass 'val' by reference to while we're at it.

[ki.stfu, 2016-05-25 17:53:07]

https://codereview.chromium.org/2009293002/diff/20001/tools/clang/blink_gc_pl...
File tools/clang/blink_gc_plugin/JsonWriter.h (right):

https://codereview.chromium.org/2009293002/diff/20001/tools/clang/blink_gc_pl...
tools/clang/blink_gc_plugin/JsonWriter.h:51: void Write(const std::string& key,
const std::string val) {
On 2016/05/25 17:45:57, hans wrote:
> Should probably pass 'val' by reference to while we're at it.

Missed that, thanks :)

[hans, 2016-05-25 17:57:32]

lgtm

[ki.stfu, 2016-05-25 18:00:40]

The CQ bit was checked by ki.stfu@gmail.com

[commit-bot: I haz the power, 2016-05-25 18:01:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009293002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009293002/40001

[commit-bot: I haz the power, 2016-05-25 18:46:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-25 18:47:51]

Description was changed from

==========
Cleanup: Pass std::string as const reference from tools/clang/

Passing std::string by reference can prevent extra copying of object.

BUG=367418
TEST=
R=thakis@chromium.org,hans@chromium.org
==========

to

==========
Cleanup: Pass std::string as const reference from tools/clang/

Passing std::string by reference can prevent extra copying of object.

BUG=367418
TEST=
R=thakis@chromium.org,hans@chromium.org

Committed: https://crrev.com/1ccf0063582e4e727cf89835d12b5c213f7b83d2
Cr-Commit-Position: refs/heads/master@{#395945}
==========

[commit-bot: I haz the power, 2016-05-25 18:47:52]

Patchset 3 (id:??) landed as
https://crrev.com/1ccf0063582e4e727cf89835d12b5c213f7b83d2
Cr-Commit-Position: refs/heads/master@{#395945}