Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2009273002: Revert of [Smart Lock] Adds UMA Metrics for actions on Account Chooser. (Closed)

Created:
4 years, 7 months ago by melandory
Modified:
4 years, 7 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Smart Lock] Adds UMA Metrics for actions on Account Chooser. (patchset #4 id:60001 of https://codereview.chromium.org/1973293002/ ) Reason for revert: Obsolete change. This CL https://codereview.chromium.org/2009773003/ does right thing. Original issue's description: > [Smart Lock] Adds UMA Metrics for actions on Account Chooser. > > Account chooser: How many clicks on an account and on “Cancel”? > > BUG=611006 > > Committed: https://crrev.com/b3da8cc062b762d4fb9b9208405a7237dc601e89 > Cr-Commit-Position: refs/heads/master@{#395844} TBR=vasilii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=611006 Committed: https://crrev.com/a762f9cfbd26b7ee744c81350f81310c3f0d94c3 Cr-Commit-Position: refs/heads/master@{#395909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M chrome/browser/password_manager/account_chooser_dialog_android.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/password_manager/core/browser/password_manager_metrics_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_manager_metrics_util.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
melandory
Created Revert of [Smart Lock] Adds UMA Metrics for actions on Account Chooser.
4 years, 7 months ago (2016-05-25 16:34:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009273002/1
4 years, 7 months ago (2016-05-25 16:35:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 16:35:43 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 16:36:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a762f9cfbd26b7ee744c81350f81310c3f0d94c3
Cr-Commit-Position: refs/heads/master@{#395909}

Powered by Google App Engine
This is Rietveld 408576698