Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2009263002: Attempt to deflake svg/custom/animate-initial-pause-unpause.html (Closed)

Created:
4 years, 7 months ago by fs
Modified:
4 years, 7 months ago
Reviewers:
davve
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt to deflake svg/custom/animate-initial-pause-unpause.html The timeout could race with load and that animation timeline start. Happened at least once in 1000 runs. Make sure to wait for an animation frame before setting the timer (the animation timeline has its zero at the time of 'load'.) Also, rewrite the test to use testharness.js. No failures in 1000 runs. BUG=350828 Committed: https://crrev.com/45ca0a5d79d8cbc9faf8470c30fc5cb02e1bbe1f Cr-Commit-Position: refs/heads/master@{#396147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -31 lines) Patch
M third_party/WebKit/LayoutTests/svg/custom/animate-initial-pause-unpause.html View 1 chunk +24 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/animate-initial-pause-unpause-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
4 years, 7 months ago (2016-05-26 07:40:10 UTC) #2
davve
Much nicer. lgtm.
4 years, 7 months ago (2016-05-26 08:17:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009263002/1
4 years, 7 months ago (2016-05-26 08:19:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 08:22:53 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 08:24:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45ca0a5d79d8cbc9faf8470c30fc5cb02e1bbe1f
Cr-Commit-Position: refs/heads/master@{#396147}

Powered by Google App Engine
This is Rietveld 408576698