Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2009253003: Clean up fx_ge.h and IWYU. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : win #

Total comments: 6

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -250 lines) Patch
M core/fxge/include/fx_ge.h View 12 chunks +33 lines, -87 lines 0 comments Download
M fpdfsdk/cfx_systemhandler.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/formfiller/cffl_iformfiller.cpp View 3 chunks +39 lines, -38 lines 0 comments Download
M fpdfsdk/fpdf_progressive.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/fpdf_sysfontinfo.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 2 chunks +5 lines, -0 lines 0 comments Download
M fpdfsdk/fsdk_baseform.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/fsdk_rendercontext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 2 2 chunks +17 lines, -18 lines 0 comments Download
M xfa/fde/fde_gedevice.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fde/fde_visualset.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fde/ifde_txtedtpage.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fde/tto/fde_textout.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.h View 1 2 4 chunks +80 lines, -75 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 1 2 13 chunks +25 lines, -25 lines 0 comments Download
M xfa/fgas/layout/fgas_rtfbreak.h View 2 chunks +1 line, -2 lines 0 comments Download
M xfa/fxbarcode/BC_TwoDimWriter.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/BC_TwoDimWriter.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Lei Zhang
I may have to fix up Windows, but PTAL.
4 years, 7 months ago (2016-05-26 02:36:48 UTC) #2
dsinclair
lgtm https://codereview.chromium.org/2009253003/diff/20001/fpdfsdk/include/fsdk_define.h File fpdfsdk/include/fsdk_define.h (right): https://codereview.chromium.org/2009253003/diff/20001/fpdfsdk/include/fsdk_define.h#newcode67 fpdfsdk/include/fsdk_define.h:67: virtual IFX_FileStream* Retain(); Should any of these virtuals ...
4 years, 7 months ago (2016-05-26 02:55:17 UTC) #3
Lei Zhang
https://codereview.chromium.org/2009253003/diff/20001/fpdfsdk/include/fsdk_define.h File fpdfsdk/include/fsdk_define.h (right): https://codereview.chromium.org/2009253003/diff/20001/fpdfsdk/include/fsdk_define.h#newcode67 fpdfsdk/include/fsdk_define.h:67: virtual IFX_FileStream* Retain(); On 2016/05/26 02:55:17, dsinclair wrote: > ...
4 years, 7 months ago (2016-05-26 04:23:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009253003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009253003/40001
4 years, 7 months ago (2016-05-26 04:39:29 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 04:39:51 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/25fa42f398d1f8007aa36531e0436dc76981...

Powered by Google App Engine
This is Rietveld 408576698