Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2009253002: Record cache freshness metric per resource type (Closed)

Created:
4 years, 7 months ago by jkarlin
Modified:
4 years, 7 months ago
Reviewers:
gavinp, rkaplow
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, asvitkine+watch_chromium.org, kinuko+cache_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record cache freshness metric per resource type We're considering prefreshing resources by resource type, so it's necessary to know how the breakdown of freshness periods since last used by resource type. BUG=614355 Committed: https://crrev.com/1b747469849d13851a4a5e9011a50548a0f45223 Cr-Commit-Position: refs/heads/master@{#395947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -13 lines) Patch
M net/http/http_cache_transaction.cc View 9 chunks +61 lines, -13 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
jkarlin
gavinp: PTAL at everything rkaplow: PTAL at histograms.xml Thanks!
4 years, 7 months ago (2016-05-25 15:45:44 UTC) #2
gavinp
lgtm
4 years, 7 months ago (2016-05-25 15:50:31 UTC) #3
jkarlin
Thanks Gavin! rkaplow@ PTAL, thanks!
4 years, 7 months ago (2016-05-25 18:31:22 UTC) #4
jkarlin
Whoops, forgot to add rkaplow. rkaplow@, PTAL at histograms.xml, thanks!
4 years, 7 months ago (2016-05-25 18:32:02 UTC) #6
rkaplow
lgtm
4 years, 7 months ago (2016-05-25 18:33:31 UTC) #7
jkarlin
Thanks!
4 years, 7 months ago (2016-05-25 18:46:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009253002/1
4 years, 7 months ago (2016-05-25 18:47:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 18:52:25 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 18:55:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b747469849d13851a4a5e9011a50548a0f45223
Cr-Commit-Position: refs/heads/master@{#395947}

Powered by Google App Engine
This is Rietveld 408576698