Fix cull nesting assertion.

src/core/SkCanvas.cpp

 
 /*
  * Copyright 2008 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "SkCanvas.h"
@@ skipping 1144 matching lines @@
 
 void SkCanvas::onPushCull(const SkRect& cullRect) {
     // do nothing. Subclasses may do something
 }
 
 void SkCanvas::onPopCull() {
     // do nothing. Subclasses may do something
 }
 
 /////////////////////////////////////////////////////////////////////////////
+#ifdef SK_DEBUG
+// Ensure that cull rects are properly nested in device space.

[robertphillips, 2014/03/20 12:23:56]

I think this is a bad name since it conflates validation with the actual push
operation.

[f(malita), 2014/03/20 13:30:58]

Renamed to validateAndTrack().

+void SkCanvas::validateCull(const SkRect& cull) {
+    SkRect mappedCull;
+    this->getTotalMatrix().mapRect(&mappedCull, cull);
+
+    // Take clipping into account.
+    SkIRect devClip, devCull;
+    this->getClipDeviceBounds(&devClip);
+    mappedCull.roundOut(&devCull);
+    if (!devCull.intersect(devClip))

[robertphillips, 2014/03/20 12:23:56]

{} needed

[f(malita), 2014/03/20 13:30:58]

Done.

+        devCull.setEmpty();
+
+    if (!fCullStack.isEmpty()
+        && !devCull.isEmpty()
+        && !fCullStack.top().contains(devCull)) {
+        SkDEBUGF(("Invalid cull: [%d %d %d %d] (previous cull: [%d %d %d %d])\n",
+                  devCull.x(), devCull.y(), devCull.right(), devCull.bottom(),
+                  fCullStack.top().x(), fCullStack.top().y(),
+                  fCullStack.top().right(), fCullStack.top().bottom()));
+
+#ifdef ASSERT_NESTED_CULLING

[robertphillips, 2014/03/20 12:23:56]

This assert seems odd inside this code block.

[f(malita), 2014/03/20 13:30:58]

Hmm, the intention is to provide an easy way to select error behavior. Maybe
DEBUGFAIL would not seem so strange? Done.

Or would you rather remove it completely?

+        SkASSERT(fCullStack.top().contains(devCull));
+#endif
+    }
+
+    fCullStack.push(devCull); // balanced in popCull
+}
+#endif
+
+void SkCanvas::pushCull(const SkRect& cullRect) {

[robertphillips, 2014/03/20 12:23:56]

this->

+    SkDEBUGCODE(validateCull(cullRect));
+
+    ++fCullCount;
+    this->onPushCull(cullRect);
+}
+
+void SkCanvas::popCull() {
+    SkASSERT(fCullStack.count() == fCullCount);
+
+    if (fCullCount > 0) {
+        SkDEBUGCODE(fCullStack.pop());
+        --fCullCount;
+        this->onPopCull();
+    }
+}
+
+/////////////////////////////////////////////////////////////////////////////
 
 void SkCanvas::internalDrawBitmap(const SkBitmap& bitmap,
                                 const SkMatrix& matrix, const SkPaint* paint) {
     if (bitmap.drawsNothing()) {
         return;
     }
 
     SkLazyPaint lazy;
     if (NULL == paint) {
         paint = lazy.init();
@@ skipping 1445 matching lines @@
     if (!bitmap.installPixels(info, pixels, rowBytes)) {
         return NULL;
     }
 
     // should this functionality be moved into allocPixels()?
     if (!bitmap.info().isOpaque()) {
         bitmap.eraseColor(0);
     }
     return SkNEW_ARGS(SkCanvas, (bitmap));
 }