Issue 200923005: Revert changes to checkout.GitCheckout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200923005: Revert changes to checkout.GitCheckout. (Closed)

Created:
6 years, 9 months ago by agable

Modified:
6 years, 9 months ago

Reviewers:
rmistry1

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, hinoka

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Revert changes to checkout.GitCheckout. Things have gone wrong. This change and subsequent fixes were not as safe as they should have been. Reverting until we can diagnose exactly what has gone wrong, and how to prevent it from happening again. This reverts commit fa3c388ec59ec7949682d2ada6300da3f6f09b5a. This reverts commit e569f50330b5d0b5cc564781a599a18674ac748b. This reverts commit 7dc11449f0cb0aacc9ef72773d4d768d9e7bf775. R=rmistry@chromium.org TBR=rmistry@chromium.org BUG=261619 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258003

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -40 lines)			Patch
	M	checkout.py	View		7 chunks	+57 lines, -40 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

agable

Committed patchset #1 manually as r258003 (presubmit successful).

6 years, 9 months ago (2014-03-19 16:47:40 UTC) #3

rmistry

6 years, 9 months ago (2014-03-19 16:48:33 UTC) #4

Message was sent while issue was closed.

On 2014/03/19 16:47:40, agable wrote:
> Committed patchset #1 manually as r258003 (presubmit successful).

You may also have to delete the existing checkout in skiabuildbot CQ to get this
to work like it did before.

Expand Messages | Collapse Messages