Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2009103002: Ensure observers are notified when an image fails to decode. (Closed)

Created:
4 years, 7 months ago by Nate Chapin
Modified:
4 years, 6 months ago
Reviewers:
eae
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure observers are notified when an image fails to decode. BUG=610990 TEST=http/tests/images/restyle-decode-error.html Committed: https://crrev.com/cbab5f331081a48a4a43a5104b80e5880bf874b9 Cr-Commit-Position: refs/heads/master@{#396000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/images/restyle-decode-error.html View 1 chunk +10 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/images/restyle-decode-error-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009103002/1
4 years, 7 months ago (2016-05-24 23:28:56 UTC) #2
Nate Chapin
eae, would you mind giving me a sanity check here? This patch corrects a simple ...
4 years, 7 months ago (2016-05-24 23:33:36 UTC) #4
eae
On 2016/05/24 23:33:36, Nate Chapin wrote: > eae, would you mind giving me a sanity ...
4 years, 7 months ago (2016-05-24 23:43:35 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-25 01:47:51 UTC) #7
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-25 01:48:06 UTC) #8
eae
LGTM
4 years, 6 months ago (2016-05-25 18:46:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009103002/1
4 years, 6 months ago (2016-05-25 21:59:17 UTC) #11
Nate Chapin
On 2016/05/24 23:43:35, eae wrote: > On 2016/05/24 23:33:36, Nate Chapin wrote: > > eae, ...
4 years, 6 months ago (2016-05-25 22:00:24 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-25 22:05:24 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-05-25 22:06:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbab5f331081a48a4a43a5104b80e5880bf874b9
Cr-Commit-Position: refs/heads/master@{#396000}

Powered by Google App Engine
This is Rietveld 408576698