gpu/command_buffer/service/gles2_cmd_decoder_autogen.h - Issue 2009073002: command_buffer: Guard on extension and profiles in the decoder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

Issue 2009073002: command_buffer: Guard on extension and profiles in the decoder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check for GL errors in the unittest Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/context_state_impl_autogen.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_0_autogen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h b/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

index 75efd2447a6b4812d95962d891883b95d4bdb000..e8852492d874b6d0a2794222df9e9c9a8f5f8778 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

@@ -2166,13 +2166,17 @@ error::Error GLES2DecoderImpl::HandleHint(uint32_t immediate_data_size,

case GL_GENERATE_MIPMAP_HINT:

if (state_.hint_generate_mipmap != mode) {

state_.hint_generate_mipmap = mode;

- glHint(target, mode);

+ if (!feature_info_->gl_version_info().is_desktop_core_profile) {

+ glHint(target, mode);

+ }

}

break;

case GL_FRAGMENT_SHADER_DERIVATIVE_HINT_OES:

if (state_.hint_fragment_shader_derivative != mode) {

state_.hint_fragment_shader_derivative = mode;

- glHint(target, mode);

+ if (feature_info_->feature_flags().oes_standard_derivatives) {

+ glHint(target, mode);

+ }

}

break;

default: