command_buffer: Guard on extension and profiles in the decoder

gpu/command_buffer/service/gles2_cmd_decoder_unittest_context_state.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include <stdint.h>
 
 #include "base/command_line.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 432 matching lines @@
   // Again, PixelStorei calls with unpack parameters are cached.
   EXPECT_CALL(*gl_, PixelStorei(_, _)).Times(0);
   cmd.Init(GL_UNPACK_ROW_LENGTH, 32);
   EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
 
   // Bind a PIXEL_UNPACK_BUFFER again.
   SetupUpdateES3UnpackParametersExpectations(gl_.get(), 32, 0);
   DoBindBuffer(GL_PIXEL_UNPACK_BUFFER, client_buffer_id_, kServiceBufferId);
 }
 
+TEST_P(GLES2DecoderManualInitTest, MipmapHintOnCoreProfile) {
+  // On a core profile, glHint(GL_GENERATE_MIPMAP_HINT) should be a noop
+  InitState init;
+  init.gl_version = "3.2";
+  InitDecoder(init);
+
+  cmds::Hint cmd;
+  cmd.Init(GL_GENERATE_MIPMAP_HINT, GL_NICEST);
+
+  EXPECT_CALL(*gl_, Hint(GL_GENERATE_MIPMAP_HINT, GL_NICEST)).Times(0);
+  EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));

[Zhenyao Mo, 2016/05/25 21:42:38]

You should check no GL error here.

+}
+
+TEST_P(GLES2DecoderManualInitTest, MipmapHintOnCompatibilityProfile) {
+  // On a compatibility profile, glHint(GL_GENERATE_MIPMAP_HINT) should be go
+  // through
+  InitState init;
+  init.gl_version = "3.2";
+  init.extensions += " GL_ARB_compatibility";
+  InitDecoder(init);
+
+  cmds::Hint cmd;
+  cmd.Init(GL_GENERATE_MIPMAP_HINT, GL_NICEST);
+
+  EXPECT_CALL(*gl_, Hint(GL_GENERATE_MIPMAP_HINT, GL_NICEST))
+      .Times(1)
+      .RetiresOnSaturation();
+  EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
+}
+
 // TODO(vmiura): Tests for VAO restore.
 
 // TODO(vmiura): Tests for ContextState::RestoreAttribute().
 
 // TODO(vmiura): Tests for ContextState::RestoreBufferBindings().
 
 // TODO(vmiura): Tests for ContextState::RestoreProgramBindings().
 
 // TODO(vmiura): Tests for ContextState::RestoreRenderbufferBindings().
 
 // TODO(vmiura): Tests for ContextState::RestoreProgramBindings().
 
 // TODO(vmiura): Tests for ContextState::RestoreGlobalState().
 
 }  // namespace gles2
 }  // namespace gpu