Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2009033002: Revert of [mojo] Use a pipe path to initialise Mojo in elevated utility processes. (Closed)

Created:
4 years, 7 months ago by Irfan
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [mojo] Use a pipe path to initialise Mojo in elevated utility processes. (patchset #22 id:420001 of https://codereview.chromium.org/1893313003/ ) Reason for revert: This is failing DrMemory tests. See https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%281%29/builds/4939 for details Original issue's description: > [mojo] Use a pipe path to initialise Mojo in elevated utility processes. > > Elevated processes can't be passed HANDLEs, so instead, IPC channels > must be initialised by passing a pipe path on the command line. For security, > passing a pipe path is only done for elevated process and no other process > types. > > BUG=604282 > > Committed: https://crrev.com/32ca1d648267a6ce2dae1417b6710089b2555f42 > Cr-Commit-Position: refs/heads/master@{#395533} TBR=rockot@chromium.org,forshaw@chromium.org,nick@chromium.org,amistry@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=604282 Committed: https://crrev.com/c69c114f40bc1d477ca436cc3b981d535659e58b Cr-Commit-Position: refs/heads/master@{#395714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -291 lines) Patch
M content/browser/child_process_launcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/child_process_launcher.cc View 4 chunks +6 lines, -18 lines 0 comments Download
M content/browser/utility_process_host_impl_browsertest.cc View 2 chunks +4 lines, -15 lines 0 comments Download
M content/child/child_thread_impl.cc View 2 chunks +3 lines, -13 lines 0 comments Download
M mojo/edk/embedder/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D mojo/edk/embedder/named_platform_channel_pair.h View 1 chunk +0 lines, -64 lines 0 comments Download
D mojo/edk/embedder/named_platform_channel_pair_win.cc View 1 chunk +0 lines, -131 lines 0 comments Download
M mojo/edk/embedder/platform_handle.h View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/edk/system/channel_win.cc View 5 chunks +0 lines, -38 lines 0 comments Download
M mojo/mojo_edk.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Irfan
Created Revert of [mojo] Use a pipe path to initialise Mojo in elevated utility processes.
4 years, 7 months ago (2016-05-24 20:18:22 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009033002/1
4 years, 7 months ago (2016-05-24 20:29:13 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-24 20:29:26 UTC) #7
Irfan
Multiple UNITIALIZED READ complaints that end up at: # 3 mojo_system_impl.dll!mojo::edk::`anonymous namespace'::ChannelWin::WriteNoLock [mojo\edk\system\channel_win.cc:290] # 4 ...
4 years, 7 months ago (2016-05-24 20:48:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009033002/1
4 years, 7 months ago (2016-05-24 22:24:35 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-24 22:24:37 UTC) #12
ncarter (slow)
rubber stamp lgtm for revert
4 years, 7 months ago (2016-05-24 22:32:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009033002/1
4 years, 7 months ago (2016-05-24 22:33:41 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 22:36:03 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 22:37:55 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c69c114f40bc1d477ca436cc3b981d535659e58b
Cr-Commit-Position: refs/heads/master@{#395714}

Powered by Google App Engine
This is Rietveld 408576698