Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2009023003: MD Settings: make bluetooth dialog resize like other settings-dialogs (Closed)

Created:
4 years, 7 months ago by Dan Beam
Modified:
4 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: make bluetooth dialog resize like other settings-dialogs Just call notifyResize() when devices change and use the same resize logic. R=stevenjb@chromium.org BUG=602538 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f16e174c0b43eb00657d768bdcc582929e9b4735 Cr-Commit-Position: refs/heads/master@{#396070}

Patch Set 1 #

Patch Set 2 : closure #

Patch Set 3 : revive #dialogDeviceList for tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Dan Beam
4 years, 7 months ago (2016-05-25 21:08:26 UTC) #2
stevenjb
lgtm. Hooray for less complexity. To test this with a large list you can open ...
4 years, 7 months ago (2016-05-25 21:14:13 UTC) #3
Dan Beam
On 2016/05/25 21:14:13, stevenjb wrote: > lgtm. Hooray for less complexity. > > To test ...
4 years, 7 months ago (2016-05-25 21:19:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009023003/1
4 years, 7 months ago (2016-05-25 21:21:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/333)
4 years, 7 months ago (2016-05-25 21:38:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009023003/20001
4 years, 7 months ago (2016-05-25 22:18:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/218500)
4 years, 7 months ago (2016-05-25 23:11:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009023003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009023003/40001
4 years, 7 months ago (2016-05-26 00:04:35 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-26 01:11:01 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 01:12:54 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f16e174c0b43eb00657d768bdcc582929e9b4735
Cr-Commit-Position: refs/heads/master@{#396070}

Powered by Google App Engine
This is Rietveld 408576698