Add a test of updating cached height for popup notifications

Add a test of updating cached height for popup notifications

This patch adds a test for the recent change: crrev.com/331d88b5161e3c77e302722198bd4bf9180bd5a4.

BUG=606808
TEST=test passes

Committed: https://crrev.com/d5b3eea1b581ba3a276337c3491c62d848bc2625
Cr-Commit-Position: refs/heads/master@{#396674}

[yoshiki, 2016-05-27 08:23:05]

Description was changed from

==========
wip

BUG=
==========

to

==========
Add a test of updating cached height for popup notifications

This patch adds a test for the recent change:
crrev.com/331d88b5161e3c77e302722198bd4bf9180bd5a4.

BUG=606808
TEST=test passes
==========

[yoshiki, 2016-05-27 08:23:05]

yoshiki@chromium.org changed reviewers:
+ skuhne@chromium.org

[yoshiki, 2016-05-27 08:23:15]

skuhne, PTAL. Thanks.

[Mr4D (OOO till 08-26), 2016-05-27 14:01:06]

Thanks for adding the test!!

lgtm

https://codereview.chromium.org/2008993004/diff/1/ash/system/web_notification...
File ash/system/web_notification/ash_popup_alignment_delegate.h (right):

https://codereview.chromium.org/2008993004/diff/1/ash/system/web_notification...
ash/system/web_notification/ash_popup_alignment_delegate.h:51: // Returns the
current system tray height.
Since this is only used by tests - could you please rename this to
system_tray_height_for_test() and maybe mention that it is only used for a test?

[yoshiki, 2016-05-30 03:15:56]

Patchset #2 (id:20001) has been deleted

[yoshiki, 2016-05-30 03:54:48]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2016-05-30 03:54:49]

The patchset sent to the CQ was uploaded after l-g-t-m from skuhne@chromium.org
Link to the patchset: https://codereview.chromium.org/2008993004/#ps60001
(title: "Rebased")

[yoshiki, 2016-05-30 03:54:55]

Thanks

https://codereview.chromium.org/2008993004/diff/1/ash/system/web_notification...
File ash/system/web_notification/ash_popup_alignment_delegate.h (right):

https://codereview.chromium.org/2008993004/diff/1/ash/system/web_notification...
ash/system/web_notification/ash_popup_alignment_delegate.h:51: // Returns the
current system tray height.
On 2016/05/27 14:01:06, Mr4D wrote:
> Since this is only used by tests - could you please rename this to
> system_tray_height_for_test() and maybe mention that it is only used for a
test?

Done.

[commit-bot: I haz the power, 2016-05-30 03:54:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2008993004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2008993004/60001

[commit-bot: I haz the power, 2016-05-30 04:28:14]

Description was changed from

==========
Add a test of updating cached height for popup notifications

This patch adds a test for the recent change:
crrev.com/331d88b5161e3c77e302722198bd4bf9180bd5a4.

BUG=606808
TEST=test passes
==========

to

==========
Add a test of updating cached height for popup notifications

This patch adds a test for the recent change:
crrev.com/331d88b5161e3c77e302722198bd4bf9180bd5a4.

BUG=606808
TEST=test passes
==========

[commit-bot: I haz the power, 2016-05-30 04:28:15]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-30 04:29:52]

Description was changed from

==========
Add a test of updating cached height for popup notifications

This patch adds a test for the recent change:
crrev.com/331d88b5161e3c77e302722198bd4bf9180bd5a4.

BUG=606808
TEST=test passes
==========

to

==========
Add a test of updating cached height for popup notifications

This patch adds a test for the recent change:
crrev.com/331d88b5161e3c77e302722198bd4bf9180bd5a4.

BUG=606808
TEST=test passes

Committed: https://crrev.com/d5b3eea1b581ba3a276337c3491c62d848bc2625
Cr-Commit-Position: refs/heads/master@{#396674}
==========

[commit-bot: I haz the power, 2016-05-30 04:29:53]

Patchset 3 (id:??) landed as
https://crrev.com/d5b3eea1b581ba3a276337c3491c62d848bc2625
Cr-Commit-Position: refs/heads/master@{#396674}