Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2008993004: Add a test of updating cached height for popup notifications (Closed)

Created:
4 years, 7 months ago by yoshiki
Modified:
4 years, 6 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test of updating cached height for popup notifications This patch adds a test for the recent change: crrev.com/331d88b5161e3c77e302722198bd4bf9180bd5a4. BUG=606808 TEST=test passes Committed: https://crrev.com/d5b3eea1b581ba3a276337c3491c62d848bc2625 Cr-Commit-Position: refs/heads/master@{#396674}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M ash/system/tray/system_tray_unittest.cc View 1 2 2 chunks +24 lines, -0 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
yoshiki
skuhne, PTAL. Thanks.
4 years, 6 months ago (2016-05-27 08:23:15 UTC) #3
Mr4D (OOO till 08-26)
Thanks for adding the test!! lgtm https://codereview.chromium.org/2008993004/diff/1/ash/system/web_notification/ash_popup_alignment_delegate.h File ash/system/web_notification/ash_popup_alignment_delegate.h (right): https://codereview.chromium.org/2008993004/diff/1/ash/system/web_notification/ash_popup_alignment_delegate.h#newcode51 ash/system/web_notification/ash_popup_alignment_delegate.h:51: // Returns the ...
4 years, 6 months ago (2016-05-27 14:01:06 UTC) #4
yoshiki
Thanks https://codereview.chromium.org/2008993004/diff/1/ash/system/web_notification/ash_popup_alignment_delegate.h File ash/system/web_notification/ash_popup_alignment_delegate.h (right): https://codereview.chromium.org/2008993004/diff/1/ash/system/web_notification/ash_popup_alignment_delegate.h#newcode51 ash/system/web_notification/ash_popup_alignment_delegate.h:51: // Returns the current system tray height. On ...
4 years, 6 months ago (2016-05-30 03:54:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008993004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008993004/60001
4 years, 6 months ago (2016-05-30 03:54:59 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-05-30 04:28:15 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 04:29:53 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d5b3eea1b581ba3a276337c3491c62d848bc2625
Cr-Commit-Position: refs/heads/master@{#396674}

Powered by Google App Engine
This is Rietveld 408576698