Chromium Code Reviews| Index: Source/modules/screen_orientation/ScreenOrientation.cpp |
| diff --git a/Source/modules/screen_orientation/ScreenOrientation.cpp b/Source/modules/screen_orientation/ScreenOrientation.cpp |
| index a5756e76fd0c81b4e325dd37d0a3c0ed532b30a6..2084b194ae6a08f3ce409cc29cdc04d4fc7c8b52 100644 |
| --- a/Source/modules/screen_orientation/ScreenOrientation.cpp |
| +++ b/Source/modules/screen_orientation/ScreenOrientation.cpp |
| @@ -130,21 +130,6 @@ const AtomicString& ScreenOrientation::orientation(Screen& screen) |
| return orientationToString(controller.orientation()); |
| } |
| -bool ScreenOrientation::lockOrientation(Screen& screen, const Vector<String>& orientationsVector) |
|
Inactive
2014/03/15 00:29:52
I think you forgot to remove it from the header as
mlamouri (slow - plz ping)
2014/03/15 00:54:47
Indeed. The all_webkit target was pretty happy wit
|
| -{ |
| - blink::WebScreenOrientations orientations = 0; |
| - for (size_t i = 0; i < orientationsVector.size(); ++i) { |
| - blink::WebScreenOrientations currentOrientation = stringToOrientations(AtomicString(orientationsVector[i])); |
| - if (!currentOrientation) |
| - return false; |
| - orientations |= currentOrientation; |
| - } |
| - if (!orientations) |
| - return false; |
| - ScreenOrientation::from(screen).lockOrientationAsync(orientations); |
| - return true; |
| -} |
| - |
| bool ScreenOrientation::lockOrientation(Screen& screen, const AtomicString& orientationString) |
| { |
| blink::WebScreenOrientations orientations = stringToOrientations(orientationString); |
|
Inactive
2014/03/15 00:31:24
Does this mean we can drop WebScreenOrientations a
mlamouri (slow - plz ping)
2014/03/15 00:54:47
Yes, we can get ride of WebScreenOrientations but
|