Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2008903002: Drop unique audio thread ID requirement. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews, hongchan, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop unique audio thread ID requirement. r391848 introduced the requirement that, once set, the audio thread ID could not be changed. This is proving too burdensome a constraint to keep, in case audio device threads do end up being stopped and new ones created. While r395182 took care of some cases where audio threads end up stopping, carefully resetting the recordeed audio thread ID, other cases remain (see associated bug.) While those could be similarly handled, precisely tracking the current audio thread ID is proving to not be worth the overhead. Hence, retire the constraint and let the audio thread processing a render quantum set its thread ID as part of executing, irrespective of what audio thread executed the previous quantum. This effectively reverts r395182. R= BUG=613902 Committed: https://crrev.com/94a98a7b9932aafbb3baeabfec458fcdeea16707 Cr-Commit-Position: refs/heads/master@{#395682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioContext.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-24 14:14:32 UTC) #2
haraken
LGTM on my side.
4 years, 7 months ago (2016-05-24 14:18:36 UTC) #3
Raymond Toy
lgtm
4 years, 7 months ago (2016-05-24 15:20:08 UTC) #4
hongchan
lgtm
4 years, 7 months ago (2016-05-24 16:08:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008903002/1
4 years, 7 months ago (2016-05-24 18:09:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 20:08:13 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 20:09:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94a98a7b9932aafbb3baeabfec458fcdeea16707
Cr-Commit-Position: refs/heads/master@{#395682}

Powered by Google App Engine
This is Rietveld 408576698