|
|
Reland of Consolidate OutputSurface constructors into GL vs Vulkan. (patchset #1 id:1 of https://codereview.chromium.org/2013743002/ )
Reason for revert:
Sorry but this patch was innocent: https://codereview.chromium.org/2006143006/ seems suspicious instead.
Original issue's description:
> Revert of Consolidate OutputSurface constructors into GL vs Vulkan. (patchset #8 id:140001 of https://codereview.chromium.org/2002303002/ )
>
> Reason for revert:
> This causes flaky test failures (e.g. https://build.chromium.org/p/chromium.gpu/builders/Linux%20Release%20%28NVIDIA%29/builds/78761)
>
> Original issue's description:
> > Consolidate OutputSurface constructors into GL vs Vulkan.
> >
> > Get rid of the many many constructors on OutputSurface, drop it down
> > to constructors for GL based compositing vs Vulkan based.
> >
> > R=boliu@chromium.org, piman, sievers
> > TBR=sky, torne
> > BUG= 487471
> > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.blink:win_blink_rel
> >
> > Committed: https://crrev.com/6daedd173180936d9c56976a276a91ff761da68a
> > Cr-Commit-Position: refs/heads/master@{#395478}
> >
> > Committed: https://crrev.com/d7b005182e7a5174db8aa8e763df67faa46c4cd5
> > Cr-Commit-Position: refs/heads/master@{#395728}
>
> TBR=boliu@chromium.org,piman@chromium.org,sievers@chromium.org,nyquist@chromium.org,sky@chromium.org,torne@chromium.org,rjkroege@chromium.org,fsamuel@chromium.org,danakj@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 487471
>
> Committed: https://crrev.com/f7bae84201b3e573a274bde0f000ee766ac13130
> Cr-Commit-Position: refs/heads/master@{#395833}
TBR=boliu@chromium.org,piman@chromium.org,sievers@chromium.org,nyquist@chromium.org,sky@chromium.org,torne@chromium.org,rjkroege@chromium.org,fsamuel@chromium.org,danakj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 487471
Committed: https://crrev.com/ea85b9dcd9951c6a52ac0fc7e6a6634dbdc0a896
Cr-Commit-Position: refs/heads/master@{#395847}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+349 lines, -484 lines) |
Patch |
 |
M |
android_webview/browser/parent_output_surface.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
blimp/client/feature/compositor/blimp_output_surface.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
blimp/client/feature/compositor/blimp_output_surface.cc
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
cc/output/gl_renderer_unittest.cc
|
View
|
|
2 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
cc/output/output_surface.h
|
View
|
|
4 chunks |
+13 lines, -16 lines |
0 comments
|
Download
|
 |
M |
cc/output/output_surface.cc
|
View
|
|
1 chunk |
+5 lines, -37 lines |
0 comments
|
Download
|
 |
M |
cc/output/output_surface_unittest.cc
|
View
|
|
3 chunks |
+10 lines, -21 lines |
0 comments
|
Download
|
 |
M |
cc/output/overlay_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
cc/output/renderer_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
cc/surfaces/surface_display_output_surface.cc
|
View
|
|
2 chunks |
+4 lines, -6 lines |
0 comments
|
Download
|
 |
M |
cc/test/failure_output_surface.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
cc/test/fake_output_surface.h
|
View
|
|
4 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
 |
M |
cc/test/fake_output_surface.cc
|
View
|
|
1 chunk |
+12 lines, -32 lines |
0 comments
|
Download
|
 |
M |
cc/test/pixel_test_output_surface.cc
|
View
|
|
4 chunks |
+7 lines, -3 lines |
0 comments
|
Download
|
 |
M |
components/display_compositor/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
components/display_compositor/buffer_queue.h
|
View
|
|
3 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
components/display_compositor/buffer_queue.cc
|
View
|
|
9 chunks |
+26 lines, -36 lines |
0 comments
|
Download
|
 |
M |
components/display_compositor/buffer_queue_unittest.cc
|
View
|
|
6 chunks |
+39 lines, -27 lines |
0 comments
|
Download
|
 |
M |
components/mus/public/cpp/lib/output_surface.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/mus/surfaces/direct_output_surface.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/mus/surfaces/direct_output_surface_ozone.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/mus/surfaces/direct_output_surface_ozone.cc
|
View
|
|
6 chunks |
+20 lines, -20 lines |
0 comments
|
Download
|
 |
M |
content/browser/compositor/browser_compositor_output_surface.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
|
View
|
|
4 chunks |
+13 lines, -13 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/compositor_impl_android.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/content_renderer.gypi
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/renderer/android/synchronous_compositor_output_surface.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/renderer/android/synchronous_compositor_output_surface.cc
|
View
|
|
2 chunks |
+6 lines, -7 lines |
0 comments
|
Download
|
 |
M |
content/renderer/gpu/compositor_output_surface.h
|
View
|
|
5 chunks |
+13 lines, -23 lines |
0 comments
|
Download
|
 |
M |
content/renderer/gpu/compositor_output_surface.cc
|
View
|
|
2 chunks |
+46 lines, -82 lines |
0 comments
|
Download
|
 |
D |
content/renderer/gpu/delegated_compositor_output_surface.h
|
View
|
|
1 chunk |
+0 lines, -31 lines |
0 comments
|
Download
|
 |
D |
content/renderer/gpu/delegated_compositor_output_surface.cc
|
View
|
|
1 chunk |
+0 lines, -28 lines |
0 comments
|
Download
|
 |
M |
content/renderer/gpu/mailbox_output_surface.h
|
View
|
|
4 chunks |
+15 lines, -12 lines |
0 comments
|
Download
|
 |
M |
content/renderer/gpu/mailbox_output_surface.cc
|
View
|
|
6 chunks |
+67 lines, -34 lines |
0 comments
|
Download
|
 |
M |
content/renderer/render_widget.cc
|
View
|
|
4 chunks |
+13 lines, -15 lines |
0 comments
|
Download
|
 |
M |
ui/compositor/test/in_process_context_factory.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 5 (1 generated)
|