Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2008893002: [printing] show symbols when using %DebugPrint (Closed)

Created:
4 years, 6 months ago by Camillo Bruni
Modified:
4 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[printing] show symbols when using %DebugPrint This CL makes sure that Symbols-keys are printed the same way for fast and slow properties. Additionally the elements and properties are marked clearer in the output. BUG= Committed: https://crrev.com/bcf520ef6e85fb880e7a9379d1356bf7f2b27639 Cr-Commit-Position: refs/heads/master@{#36550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M src/objects-printer.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Camillo Bruni
PTAL
4 years, 6 months ago (2016-05-25 16:19:05 UTC) #3
Jakob Kummerow
lgtm
4 years, 6 months ago (2016-05-27 13:11:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008893002/1
4 years, 6 months ago (2016-05-27 13:57:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 14:25:12 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 14:26:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcf520ef6e85fb880e7a9379d1356bf7f2b27639
Cr-Commit-Position: refs/heads/master@{#36550}

Powered by Google App Engine
This is Rietveld 408576698