Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2008883002: [turbofan] Fix escape analysis of sub-word element access. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix escape analysis of sub-word element access. This fixes data-flow tracking of sub-word (i.e. int8 or int16) element accesses withing the escape analysis. In essense this makes sure that we only ever consider the offset for loads and stores on tracked objects and avoid mangling the offset on untracked ones. R=jarin@chromium.org TEST=cctest/test-api/Fixed[U]Int[8,16]Array Committed: https://crrev.com/5dc600528112fb4dcad1fc628a41412d78b933ef Cr-Commit-Position: refs/heads/master@{#36573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -27 lines) Patch
M src/compiler/escape-analysis.cc View 6 chunks +24 lines, -27 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-24 12:45:08 UTC) #1
Jarin
lgtm
4 years, 6 months ago (2016-05-30 08:12:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008883002/1
4 years, 6 months ago (2016-05-30 08:13:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 08:37:39 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 08:38:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5dc600528112fb4dcad1fc628a41412d78b933ef
Cr-Commit-Position: refs/heads/master@{#36573}

Powered by Google App Engine
This is Rietveld 408576698