Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2008843004: Remove unnecessary inclusions of LayoutObject-derived headers in core/html/ (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
eae
CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary inclusions of LayoutObject-derived headers in core/html/ BUG=614015 TBR=eae@chromium.org Committed: https://crrev.com/997542543ad16f6bb06b2464116b4f01097d747b Cr-Commit-Position: refs/heads/master@{#395984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDialogElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableElement.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-25 19:29:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008843004/1
4 years, 7 months ago (2016-05-25 19:29:47 UTC) #5
eae
LGTM
4 years, 7 months ago (2016-05-25 20:24:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 20:50:10 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 20:51:41 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/997542543ad16f6bb06b2464116b4f01097d747b
Cr-Commit-Position: refs/heads/master@{#395984}

Powered by Google App Engine
This is Rietveld 408576698