Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7032)

Unified Diff: chrome/test/data/webui/settings/settings_menu_test.js

Issue 2008843003: [MD settings] redesign of side nav (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change defaults Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/settings_menu_test.js
diff --git a/chrome/test/data/webui/settings/settings_menu_test.js b/chrome/test/data/webui/settings/settings_menu_test.js
index f2a3f0022168fafe6e8b4bc8f75ea134f0e38ba9..727a667ae395e71c02357621ad8f08aac9c18bcc 100644
--- a/chrome/test/data/webui/settings/settings_menu_test.js
+++ b/chrome/test/data/webui/settings/settings_menu_test.js
@@ -12,39 +12,35 @@ cr.define('settings_menu', function() {
setup(function() {
PolymerTest.clearBody();
settingsMenu = document.createElement('settings-menu');
+ settingsMenu.currentRoute = {
+ page: 'basic', section: '', subpage: []
+ };
document.body.appendChild(settingsMenu);
});
teardown(function() { settingsMenu.remove(); });
+ test('openAdvanced', function() {
+ settingsMenu.fire('toggle-advanced-page', true);
+ Polymer.dom.flush();
+ assertTrue(settingsMenu.$.advancedPage.opened);
+ });
+
test('upAndDownIcons', function() {
// There should be different icons for a top level menu being open
// vs. being closed. E.g. arrow-drop-up and arrow-drop-down.
- settingsMenu.currentRoute = {
- page: 'advanced', section: 'reset', subpage: []
- };
var ironIconElement = settingsMenu.$.advancedPage.querySelector(
'.menu-trigger iron-icon');
assertTrue(!!ironIconElement);
+
+ settingsMenu.fire('toggle-advanced-page', true);
+ Polymer.dom.flush();
var openIcon = ironIconElement.icon;
assertTrue(!!openIcon);
- // Changing to basic will close advanced.
- settingsMenu.currentRoute = {page: 'basic', section: '', subpage: []};
- assertNotEquals(openIcon, ironIconElement.icon);
- });
- test('defaultToBasic', function() {
- settingsMenu.currentRoute = {page: 'basic', section: '', subpage: []};
- assertFalse(settingsMenu.$.advancedPage.opened);
- assertTrue(settingsMenu.$.basicPage.opened);
- });
-
- test('openAdvanced', function() {
- settingsMenu.currentRoute = {
- page: 'advanced', section: '', subpage: []
- };
- assertTrue(settingsMenu.$.advancedPage.opened);
- assertFalse(settingsMenu.$.basicPage.opened);
+ settingsMenu.fire('toggle-advanced-page', false);
+ Polymer.dom.flush();
+ assertNotEquals(openIcon, ironIconElement.icon);
});
test('openResetSection', function() {
@@ -52,8 +48,6 @@ cr.define('settings_menu', function() {
page: 'advanced', section: 'reset', subpage: []
};
var advancedPage = settingsMenu.$.advancedPage;
- assertTrue(advancedPage.opened);
- assertFalse(settingsMenu.$.basicPage.opened);
assertEquals('reset',
advancedPage.querySelector('paper-menu').selected);
});

Powered by Google App Engine
This is Rietveld 408576698