Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 2008843003: [MD settings] redesign of side nav (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change defaults Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_menu/settings_menu.html
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html
index f79fb67275b666656874f11f4e544de0d7667682..0d4b5917a3686f7d83a0e99d5f128025e8483887 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.html
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html
@@ -36,24 +36,28 @@
padding: 0;
}
- paper-submenu > div {
+ #basicPage {
margin-top: 8px;
}
- paper-submenu {
+ .page-menu > div {
+ margin-top: 8px;
+ }
+
+ .page-menu {
--paper-menu-selected-item: {
font-weight: 500;
};
}
- paper-submenu paper-menu {
+ .page-menu paper-menu {
--paper-menu-selected-item: {
color: var(--google-blue-500);
font-weight: 500;
};
}
- paper-submenu div {
+ .page-menu div {
-webkit-margin-start: 24px;
align-items: center;
display: flex;
@@ -69,11 +73,7 @@
}
</style>
<paper-menu name="root-menu">
- <paper-submenu data-page="basic" id="basicPage" opened="{{basicOpened_}}">
- <div class="menu-trigger" data-section="" on-tap="openPage_">
- <span>$i18n{basicPageTitle}</span>
- <iron-icon icon="[[arrowState_(basicOpened_)]]"></iron-icon>
- </div>
+ <div class="page-menu" data-page="basic" id="basicPage">
<paper-menu attr-for-selected="data-section" class="menu-content"
data-page="basic" id="basicMenu">
<if expr="chromeos">
@@ -111,8 +111,8 @@
$i18n{onStartup}
</div>
</paper-menu>
- </paper-submenu>
- <paper-submenu id="advancedPage" data-page="advanced"
+ </div>
+ <paper-submenu class="page-menu" id="advancedPage" data-page="advanced"
opened="{{advancedOpened_}}">
<div class="menu-trigger" data-section="" on-tap="openPage_">
<span>$i18n{advancedPageTitle}</span>
@@ -169,7 +169,7 @@
</paper-menu>
</paper-submenu>
<div class="separator"></div>
- <paper-submenu data-page="about">
+ <paper-submenu class="page-menu" data-page="about">
<div class="menu-trigger" on-tap="openPage_" data-section="">
$i18n{aboutPageTitle}
</div>

Powered by Google App Engine
This is Rietveld 408576698