Chromium Code Reviews| Index: chrome/browser/resources/settings/settings_menu/settings_menu.html |
| diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html |
| index 7483615a57b671768052f60d0645139d2dad3ca7..df9dd6d5118a5cba6a4bbf14a01afacd9297291a 100644 |
| --- a/chrome/browser/resources/settings/settings_menu/settings_menu.html |
| +++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html |
| @@ -36,24 +36,28 @@ |
| padding: 0; |
| } |
| - paper-submenu > div { |
| + #basicPage { |
| margin-top: 8px; |
| } |
| - paper-submenu { |
| + .page-menu > div { |
| + margin-top: 8px; |
| + } |
| + |
| + .page-menu { |
| --paper-menu-selected-item: { |
| font-weight: 500; |
| }; |
| } |
| - paper-submenu paper-menu { |
| + .page-menu paper-menu { |
| --paper-menu-selected-item: { |
| color: var(--google-blue-500); |
| font-weight: 500; |
| }; |
| } |
| - paper-submenu div { |
| + .page-menu div { |
| @apply(--layout-center); |
| -webkit-margin-start: 24px; |
| display: flex; |
| @@ -69,11 +73,8 @@ |
| } |
| </style> |
| <paper-menu name="root-menu"> |
| - <paper-submenu data-page="basic" id="basicPage" opened="{{basicOpened_}}"> |
| - <div class="menu-trigger" data-section="" on-tap="openPage_"> |
| - <span>$i18n{basicPageTitle}</span> |
| - <iron-icon icon="[[arrowState_(basicOpened_)]]"></iron-icon> |
| - </div> |
| + <div class="page-menu" data-page="basic" id="basicPage" |
| + hidden$="!basicOpened_"> |
|
Dan Beam
2016/05/31 23:28:24
where is basicOpened_ defined? also, why would we
dschuyler
2016/06/02 01:05:37
Done.
|
| <paper-menu attr-for-selected="data-section" class="menu-content" |
| data-page="basic" id="basicMenu"> |
| <if expr="chromeos"> |
| @@ -111,10 +112,10 @@ |
| $i18n{onStartup} |
| </div> |
| </paper-menu> |
| - </paper-submenu> |
| - <paper-submenu id="advancedPage" data-page="advanced" |
| + </div> |
| + <paper-submenu class="page-menu" id="advancedPage" data-page="advanced" |
| opened="{{advancedOpened_}}"> |
| - <div class="menu-trigger" data-section="" on-tap="openPage_"> |
| + <div class="menu-trigger" data-section="" on-tap="toggleAdvancedPage_"> |
| <span>$i18n{advancedPageTitle}</span> |
| <iron-icon icon="[[arrowState_(advancedOpened_)]]"></iron-icon> |
| </div> |
| @@ -167,7 +168,7 @@ |
| </paper-menu> |
| </paper-submenu> |
| <div class="separator"></div> |
| - <paper-submenu data-page="about"> |
| + <paper-submenu class="page-menu" data-page="about"> |
| <div class="menu-trigger" on-tap="openPage_" data-section=""> |
| $i18n{aboutPageTitle} |
| </div> |