Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: tests/standalone/io/web_socket_ping_test.dart

Issue 20088002: Make web_socket_ping_test pass on simulators, where it takes > 100ms to send data between sockets(!… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/web_socket_ping_test.dart
diff --git a/tests/standalone/io/web_socket_ping_test.dart b/tests/standalone/io/web_socket_ping_test.dart
index b760644747f15a7f447e5eed5b7687872026da7f..29fec923d550e218b1352ca17c626536d6d060d8 100644
--- a/tests/standalone/io/web_socket_ping_test.dart
+++ b/tests/standalone/io/web_socket_ping_test.dart
@@ -15,7 +15,7 @@ import "dart:io";
void testPing(int totalConnections) {
HttpServer.bind('localhost', 0).then((server) {
server.transform(new WebSocketTransformer()).listen((webSocket) {
- webSocket.pingInterval = const Duration(milliseconds: 100);
+ webSocket.pingInterval = const Duration(milliseconds: 500);
webSocket.drain();
});
@@ -23,9 +23,9 @@ void testPing(int totalConnections) {
for (int i = 0; i < totalConnections; i++) {
futures.add(
WebSocket.connect('ws://localhost:${server.port}').then((webSocket) {
- webSocket.pingInterval = const Duration(milliseconds: 100);
+ webSocket.pingInterval = const Duration(milliseconds: 500);
webSocket.drain();
- new Timer(const Duration(seconds: 1), () {
+ new Timer(const Duration(seconds: 2), () {
// Should not be closed yet.
Expect.equals(null, webSocket.closeCode);
webSocket.close();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698