Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: ui/views/accessibility/ax_window_obj_wrapper.cc

Issue 2008773002: Begin using ChromeVox Next to read tab and window titles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/accessibility/ax_window_obj_wrapper.cc
diff --git a/ui/views/accessibility/ax_window_obj_wrapper.cc b/ui/views/accessibility/ax_window_obj_wrapper.cc
index ebdb650d1a6b484f523067246ef311ad81963963..d2b1cbf0692668e640b3e19ae625401a3069fbde 100644
--- a/ui/views/accessibility/ax_window_obj_wrapper.cc
+++ b/ui/views/accessibility/ax_window_obj_wrapper.cc
@@ -57,8 +57,7 @@ void AXWindowObjWrapper::Serialize(ui::AXNodeData* out_node_data) {
// Root windows currently have a non readable name (e.g. Display1234...);
// ignore them unless the window is the only node in the tree.
if (window_->parent() || window_->children().size() == 0) {
- out_node_data->AddStringAttribute(ui::AX_ATTR_NAME,
- base::UTF16ToUTF8(window_->title()));
+ out_node_data->AddStringAttribute(ui::AX_ATTR_NAME, window_->name());
}
}
@@ -66,6 +65,10 @@ int32_t AXWindowObjWrapper::GetID() {
return AXAuraObjCache::GetInstance()->GetID(window_);
}
+void AXWindowObjWrapper::OnWindowTitleChanged(aura::Window* window) {
+ AXAuraObjCache::GetInstance()->Remove(window);
dmazzoni 2016/05/25 15:18:00 Does it get re-added? Why delete it rather than tr
David Tseng 2016/05/25 16:08:23 Removed this; went with adding the name on the wid
+}
+
void AXWindowObjWrapper::OnWindowDestroyed(aura::Window* window) {
AXAuraObjCache::GetInstance()->Remove(window);
}

Powered by Google App Engine
This is Rietveld 408576698