[Extensions UI] Remove all traces of the chevron

[Extensions UI] Remove all traces of the chevron

BUG=610793
Committed: https://crrev.com/9eb5ed4a472df5b600c76941262bb8e1f86ee41b
Cr-Commit-Position: refs/heads/master@{#395756}

[Devlin, 2016-05-24 00:16:49]

Description was changed from

==========
linux

BUG=
==========

to

==========
[Extensions UI] Remove all traces of the chevron

BUG=610793
==========

[Devlin, 2016-05-24 17:37:43]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-05-24 17:39:39]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org, estade@chromium.org, sky@chromium.org

[Devlin, 2016-05-24 17:39:40]

Yay, it's dead!

Scott, Avi, and Evan, can you please take a look?
Scott: ui/views, ui/toolbar
Avi: ui/cocoa
Evan: themes (and also double-checking that there wasn't anything else left
over)

Cheers

[Evan Stade, 2016-05-24 17:58:55]

awesome

https://codereview.chromium.org/2008763002/diff/20001/chrome/browser/themes/b...
File chrome/browser/themes/browser_theme_pack.cc (right):

https://codereview.chromium.org/2008763002/diff/20001/chrome/browser/themes/b...
chrome/browser/themes/browser_theme_pack.cc:52: const int kThemePackVersion =
41;
think you need to bump this now

https://codereview.chromium.org/2008763002/diff/20001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/toolbar_actions_bar.cc (right):

https://codereview.chromium.org/2008763002/diff/20001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/toolbar_actions_bar.cc:216: (icons * IconWidth(true))
- platform_settings_.item_spacing;
nit: i think most of this fn can be rewritten as

return icons * IconWidth(true) + platform_settings_.item_spacing;

https://codereview.chromium.org/2008763002/diff/20001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc (right):

https://codereview.chromium.org/2008763002/diff/20001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc:227: // The minimum
width should be just enough some padding.
I'm stymied by this sentence

[Avi (use Gerrit), 2016-05-24 18:17:58]

cocoa lgtm

[sky, 2016-05-24 20:33:38]

LGTM

[Devlin, 2016-05-24 21:59:01]

https://codereview.chromium.org/2008763002/diff/20001/chrome/browser/themes/b...
File chrome/browser/themes/browser_theme_pack.cc (right):

https://codereview.chromium.org/2008763002/diff/20001/chrome/browser/themes/b...
chrome/browser/themes/browser_theme_pack.cc:52: const int kThemePackVersion =
41;
On 2016/05/24 17:58:55, Evan Stade wrote:
> think you need to bump this now

Done.

https://codereview.chromium.org/2008763002/diff/20001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/toolbar_actions_bar.cc (right):

https://codereview.chromium.org/2008763002/diff/20001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/toolbar_actions_bar.cc:216: (icons * IconWidth(true))
- platform_settings_.item_spacing;
On 2016/05/24 17:58:55, Evan Stade wrote:
> nit: i think most of this fn can be rewritten as
> 
> return icons * IconWidth(true) + platform_settings_.item_spacing;

Done.

https://codereview.chromium.org/2008763002/diff/20001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc (right):

https://codereview.chromium.org/2008763002/diff/20001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc:227: // The minimum
width should be just enough some padding.
On 2016/05/24 17:58:55, Evan Stade wrote:
> I'm stymied by this sentence

Rephrased to be more clear.

[Evan Stade, 2016-05-24 22:07:18]

lgtm

https://codereview.chromium.org/2008763002/diff/40001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/toolbar_actions_bar.cc (right):

https://codereview.chromium.org/2008763002/diff/40001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/toolbar_actions_bar.cc:226: 0, available_space +
platform_settings_.item_spacing) / IconWidth(true));
optional nit: pixels - platform_settings_.item_spacing, get rid of
available_space

[Devlin, 2016-05-25 00:38:46]

https://codereview.chromium.org/2008763002/diff/40001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/toolbar_actions_bar.cc (right):

https://codereview.chromium.org/2008763002/diff/40001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/toolbar_actions_bar.cc:226: 0, available_space +
platform_settings_.item_spacing) / IconWidth(true));
On 2016/05/24 22:07:18, Evan Stade wrote:
> optional nit: pixels - platform_settings_.item_spacing, get rid of
> available_space

Done.

[Devlin, 2016-05-25 00:38:51]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-05-25 00:38:51]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
sky@chromium.org, estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2008763002/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2016-05-25 00:40:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2008763002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2008763002/60001

[commit-bot: I haz the power, 2016-05-25 00:46:23]

Description was changed from

==========
[Extensions UI] Remove all traces of the chevron

BUG=610793
==========

to

==========
[Extensions UI] Remove all traces of the chevron

BUG=610793
==========

[commit-bot: I haz the power, 2016-05-25 00:46:24]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-25 00:47:27]

Description was changed from

==========
[Extensions UI] Remove all traces of the chevron

BUG=610793
==========

to

==========
[Extensions UI] Remove all traces of the chevron

BUG=610793

Committed: https://crrev.com/9eb5ed4a472df5b600c76941262bb8e1f86ee41b
Cr-Commit-Position: refs/heads/master@{#395756}
==========

[commit-bot: I haz the power, 2016-05-25 00:47:29]

Patchset 3 (id:??) landed as
https://crrev.com/9eb5ed4a472df5b600c76941262bb8e1f86ee41b
Cr-Commit-Position: refs/heads/master@{#395756}