Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2008753002: Revert of In LayoutTests PRESUBMIT, Don't check for all-pass baseline files in platform and virtual. (Closed)

Created:
4 years, 7 months ago by caseq
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of In LayoutTests PRESUBMIT, Don't check for all-pass baseline files in platform and virtual. (patchset #4 id:60001 of https://codereview.chromium.org/2002513002/ ) Reason for revert: This broke presubmit on layout tests with: NameError: global name 'expected_files' is not defined Original issue's description: > Don't check for all-pass baseline files in platform and virtual. > > BUG=613387 > > Committed: https://crrev.com/84044bffc3a99a4eb785ad1b207677a460d6a8e8 > Cr-Commit-Position: refs/heads/master@{#395370} TBR=dpranke@chromium.org,tkent@chromium.org,qyearsley@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=613387 Committed: https://crrev.com/b8039077e177e3a636caf28492e9f30c13d97060 Cr-Commit-Position: refs/heads/master@{#395438}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -28 lines) Patch
M third_party/WebKit/LayoutTests/PRESUBMIT.py View 2 chunks +2 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
caseq
Created Revert of In LayoutTests PRESUBMIT, Don't check for all-pass baseline files in platform and ...
4 years, 7 months ago (2016-05-23 22:22:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008753002/1
4 years, 7 months ago (2016-05-23 22:23:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 22:25:11 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b8039077e177e3a636caf28492e9f30c13d97060 Cr-Commit-Position: refs/heads/master@{#395438}
4 years, 7 months ago (2016-05-23 22:27:57 UTC) #6
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-23 22:32:50 UTC) #7
qyearsley
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2006963002/ by qyearsley@chromium.org. ...
4 years, 7 months ago (2016-05-23 23:02:05 UTC) #8
qyearsley
4 years, 7 months ago (2016-05-23 23:03:27 UTC) #9
Message was sent while issue was closed.
lgtm -- pylint or such would have caught this error but I didn't run it (and it
wasn't run automatically) -- sorry about this :-/

Powered by Google App Engine
This is Rietveld 408576698