Remove broken source/code caching support for Modules in d8

Remove broken source/code caching support for Modules in d8

The busted logic caused us to go down the SCRIPT path internally,
causing us to fail the test262 tests that attempt to induce parse
errors at the top level.

R=littledan@chromium.org
BUG=v8:4985
Committed: https://crrev.com/e9435eb9a5af6bf01a22206a4c1a7e69b4b0616a
Cr-Commit-Position: refs/heads/master@{#36563}

[Dan Ehrenberg, 2016-05-27 09:51:18]

lgtm

https://codereview.chromium.org/2008743002/diff/1/src/d8.cc
File src/d8.cc (left):

https://codereview.chromium.org/2008743002/diff/1/src/d8.cc#oldcode362
src/d8.cc:362: source_type == SCRIPT
Add a check here that source_type == SCRIPT?

[adamk, 2016-05-27 18:53:07]

https://codereview.chromium.org/2008743002/diff/1/src/d8.cc
File src/d8.cc (left):

https://codereview.chromium.org/2008743002/diff/1/src/d8.cc#oldcode362
src/d8.cc:362: source_type == SCRIPT
On 2016/05/27 09:51:18, Dan Ehrenberg wrote:
> Add a check here that source_type == SCRIPT?

Done.

[adamk, 2016-05-27 18:53:38]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-05-27 18:53:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/2008743002/#ps20001
(title: "Added DCHECK")

[commit-bot: I haz the power, 2016-05-27 18:53:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2008743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2008743002/20001

[commit-bot: I haz the power, 2016-05-27 19:22:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-27 19:23:00]

Description was changed from

==========
Remove broken source/code caching support for Modules in d8

The busted logic caused us to go down the SCRIPT path internally,
causing us to fail the test262 tests that attempt to induce parse
errors at the top level.

R=littledan@chromium.org
BUG=v8:4985
==========

to

==========
Remove broken source/code caching support for Modules in d8

The busted logic caused us to go down the SCRIPT path internally,
causing us to fail the test262 tests that attempt to induce parse
errors at the top level.

R=littledan@chromium.org
BUG=v8:4985

Committed: https://crrev.com/e9435eb9a5af6bf01a22206a4c1a7e69b4b0616a
Cr-Commit-Position: refs/heads/master@{#36563}
==========

[commit-bot: I haz the power, 2016-05-27 19:23:01]

Patchset 2 (id:??) landed as
https://crrev.com/e9435eb9a5af6bf01a22206a4c1a7e69b4b0616a
Cr-Commit-Position: refs/heads/master@{#36563}