Add migration from CaCert NSS nicknames to PEM.

chromeos/network/network_cert_migrator.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_NETWORK_NETWORK_CERT_MIGRATOR_H_
+#define CHROMEOS_NETWORK_NETWORK_CERT_MIGRATOR_H_
+
+#include "base/basictypes.h"
+#include "base/memory/weak_ptr.h"
+#include "chromeos/cert_loader.h"
+#include "chromeos/chromeos_export.h"
+#include "chromeos/network/network_state_handler_observer.h"
+
+namespace chromeos {
+
+class NetworkStateHandler;
+
+// Migrates network configurations from deprecated CaCertNSS properties to
+// CaCertPEM.
+class CHROMEOS_EXPORT NetworkCertMigrator : public NetworkStateHandlerObserver,
+                                            public CertLoader::Observer {
+ public:
+  NetworkCertMigrator();
+  virtual ~NetworkCertMigrator();
+  void Init(NetworkStateHandler* network_state_handler);

[stevenjb, 2013/07/29 17:53:03]

For consistency, make Init private and NetworkHandler (and any tests) friends.

[pneubeck (no reviews), 2013/08/05 08:51:22]

I can do that and should then also make the cstor and dstor private. But AFAIU
this is not the way we usually choose visibility in Chrome/OS.
Visibility is used to separate between implementation details of this class and
the interface that can be used from the outside. It's not used to decide who
actually can access this class; for that we only have the separation into
components.

btw. this class is only exported because its currently required for the
unittests. If we would fix that, I could remove the CHROMEOS_EXPORT.

[stevenjb, 2013/08/05 18:28:09]

When I bundled the Network*Handler classes to be owned by and accessed through
NetworkHandler, I made the constructor/Init methods private (and NetworkHandler
a friend) so that the classes would not get instantiated elsewhere (except in
tests which are also explicitly made friends). Maybe this was unnecessarily
paranoid, but it seemed prudent at the time. If this is going to be owned by
NetworkHandler I'd prefer to at least be consistent with other similar classes.

[pneubeck (no reviews), 2013/08/06 07:54:14]

Done.

+
+ private:
+  class MigrationTask;
+
+   // NetworkStateHandlerObserver overrides
+  virtual void NetworkListChanged() OVERRIDE;
+
+  // CertLoader::Observer overrides
+  virtual void OnCertificatesLoaded(const net::CertificateList& cert_list,
+                                    bool initial_load) OVERRIDE;
+
+  // Unowned associated NetworkStateHandler* (global or test instance).
+  NetworkStateHandler* network_state_handler_;
+
+  base::WeakPtrFactory<NetworkCertMigrator> weak_ptr_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(NetworkCertMigrator);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_NETWORK_NETWORK_CERT_MIGRATOR_H_