Add migration from CaCert NSS nicknames to PEM.

chromeos/network/network_cert_handler.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_NETWORK_NETWORK_CERT_HANDLER_H_
+#define CHROMEOS_NETWORK_NETWORK_CERT_HANDLER_H_
+
+#include "base/memory/weak_ptr.h"
+#include "chromeos/cert_loader.h"
+#include "chromeos/chromeos_export.h"
+#include "chromeos/network/network_state_handler_observer.h"
+
+namespace chromeos {
+
+class NetworkStateHandler;
+
+// Responsible for:
+// * Migration from deprecated CaCertNSS properties to CaCertPEM.

[Mattias Nissler (ping if slow), 2013/07/29 10:08:15]

Seems odd to have a single-item list :)

[pneubeck (no reviews), 2013/07/29 13:15:08]

I add first thought that it would make sense to add more functionality to this
class in upcoming CLs (like the client certificate pattern matching).
But I think that is a bad idea, now. E.g. the two tasks don't have so much in
common and testing will get more difficult.

Done.

+class CHROMEOS_EXPORT NetworkCertHandler : public NetworkStateHandlerObserver,

[Mattias Nissler (ping if slow), 2013/07/29 10:08:15]

If it's just doing migration, why not name it NetworkCertMigrationHelper or
similar?

[pneubeck (no reviews), 2013/07/29 13:15:08]

Done.

+                                           public CertLoader::Observer {
+ public:
+  NetworkCertHandler();
+  virtual ~NetworkCertHandler();
+  void Init(NetworkStateHandler* network_state_handler);
+
+ protected:
+  class MigrationHelper;
+
+   // NetworkStateHandlerObserver overrides
+  virtual void NetworkListChanged() OVERRIDE;
+
+  // CertLoader::Observer overrides
+  virtual void OnCertificatesLoaded(const net::CertificateList& cert_list,
+                                    bool initial_load) OVERRIDE;
+
+  // Unowned associated NetworkStateHandler* (global or test instance).
+  NetworkStateHandler* network_state_handler_;
+
+  base::WeakPtrFactory<NetworkCertHandler> weak_ptr_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(NetworkCertHandler);

[Mattias Nissler (ping if slow), 2013/07/29 10:08:15]

#include "base/basictypes.h"

[pneubeck (no reviews), 2013/07/29 13:15:08]

Done.

+};
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_NETWORK_NETWORK_CERT_HANDLER_H_
+

[Mattias Nissler (ping if slow), 2013/07/29 10:08:15]

remove trailing newline

[pneubeck (no reviews), 2013/07/29 13:15:08]

Done.